Repository navigation
Add Generic ESP32S3 Supermini - #1828
Merged
Merged
Conversation
Contributor
Author
|
Interesting, the CI fails on the same check-boards.py error I got when I tried to run it. |
Contributor
Author
|
I was missing the closed quote on the image. It would be nice if the check-boards.py had a little nicer failure message. |
makermelissa
approved these changes
Oct 19, 2026
makermelissa
left a comment
makermelissa
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier this week I did a PR to add this new board with no known manufacturer. The board had USB VID/PIDs registered by someone in 2024 and a board definition for the tinyuf2 bootloader which has been being made. I managed to collide with @unconditional who was also doing a new board PR on the same day. Since my PR contained the registered PID it was merged.
For the record
Merged PR: adafruit/circuitpython#11563
@unconditional 's PR: adafruit/circuitpython#11557
I tried to run tools/check-boards.py and check-images.py but they seem to be broken.