fix: resolve audit/license failures - #784
Open
HarithaVattikuti wants to merge 2 commits into
Open
Conversation
…ense cache, rebuild dist - Regenerated package-lock.json to pick up brace-expansion@5.0.9 (fixes GHSA-rgw5-rvv9-x895, a DoS via unbounded intermediate arrays), which is already permitted by minimatch's existing ^5.0.8 semver range. - Refreshed .licenses/npm cache to match the updated dependency tree. - Added minimatch to the licensed.yml reviewed list: its detected license text doesn't cleanly match Blue Oak 1.0.0, which is already in the allowed list. - Rebuilt dist/setup and dist/cache-save from source. npm audit --audit-level=high now reports 0 vulnerabilities; licensed status reports 0 errors; npm run pre-checkin passes locally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the Node.js dependency lockfile, bundled dist artifacts, and license metadata to resolve basic-validation.yml failures caused by npm audit high-severity findings and licensed mismatches.
Changes:
- Regenerates
package-lock.jsonto pull in patched transitive dependencies (notablybrace-expansion). - Refreshes
dist/cache-save/index.js(rebundled output) to include updated dependency code. - Updates
licensedcaches/metadata and addsminimatchto the reviewed list to keep license checks passing.
Reviewed changes
Copilot reviewed 22 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package-lock.json | Updates resolved dependency tree to address audit findings (incl. brace-expansion/minimatch). |
| dist/cache-save/index.js | Rebuilt bundled JS output reflecting updated dependency versions and security-related upstream changes. |
| .licenses/npm/xml-naming.dep.yml | Adds new cached license entry for xml-naming@0.3.0. |
| .licenses/npm/xml-naming-0.1.0.dep.yml | Removes old cached license entry for xml-naming@0.1.0. |
| .licenses/npm/undici.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/strnum.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/minimatch-10.2.6.dep.yml | Updates cached version/license classification for minimatch@10.2.6. |
| .licenses/npm/fast-xml-parser.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/fast-xml-builder.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/brace-expansion-5.0.9.dep.yml | Updates cached version to match patched brace-expansion. |
| .licenses/npm/brace-expansion-1.1.18.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/@typespec/ts-http-runtime.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/@azure/storage-common.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/@azure/storage-blob.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/@azure/logger.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/@azure/core-xml.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/@azure/core-util.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/@azure/core-tracing.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/@azure/core-rest-pipeline.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/@azure/core-paging.dep.yml | Updates cached version/text to match updated lockfile. |
| .licenses/npm/@azure/core-http-compat.dep.yml | Updates cached version/homepage to match updated lockfile. |
| .licenses/npm/@azure/core-client.dep.yml | Updates cached version to match updated lockfile. |
| .licenses/npm/@azure/core-auth.dep.yml | Updates cached version/homepage to match updated lockfile. |
| .licenses/npm/@azure/abort-controller.dep.yml | Updates cached version/text to match updated lockfile. |
| .licensed.yml | Adds minimatch to the manually reviewed dependency list. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing
basic-validation.ymlrun onmain(npm audit high-severity vulnerability).Root cause
npm audit --audit-level=highfailed with a high-severity DoS vulnerability inbrace-expansion(GHSA-rgw5-rvv9-x895). The committedpackage-lock.jsonwas stale —minimatch's own^5.0.8semver range already permits the fixed5.0.9release, no override was needed.Changes
package-lock.json(freshnpm install) — resolvesbrace-expansionto5.0.9..licenses/npmcache (licensed cache) to match the updated dependency tree.minimatchto thelicensed.ymlreviewed list — its license text doesn't cleanly auto-detect as Blue Oak 1.0.0, which is already in theallowedlist.dist/setup/index.jsanddist/cache-save/index.js.Validation
npm audit --audit-level=high→ 0 vulnerabilitieslicensed status→ 0 errorsnpm run pre-checkin(format, lint, build, test) → all pass, 122/122 tests