Conversation
This makes 2 small optimizations for the dataquery API. 1. There is no reason to convert the iterator of matchCandidates to an array just to get the count. Just use iterator_count instead. 2. The temporary accesscandidates table inserts all candidates at once. Do it in batches of 2000 in order to put a limit on the size of the insert statement string generated.
github-actions
Bot
added
Language: PHP
HenriRabalais
approved these changes
Oct 1, 2026
HenriRabalais
left a comment
HenriRabalais
left a comment
Collaborator
There was a problem hiding this comment.
looks good! approving so it can go in once the checks are green.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes 2 small optimizations for the dataquery API.