Repository navigation
test: cover estimateSellProceeds edge cases (#403) - #1270
Merged
Chucks1093 merged 1 commit intoOct 27, 2026
Merged
Conversation
estimateSellProceeds (added in accesslayerorg#419) shipped with no dedicated test coverage. accesslayerorg#419 merged into main instead of dev, so its closes tag never auto-closed the issue even though the helper is already on dev. Adds coverage for the happy path and every null/invalid-input guard clause: missing key price, missing current supply, non-positive sell quantity, and non-finite values. Closes accesslayerorg#403
Member
✅ PR Ready for ReviewDue to a recent malware incident affecting our repositories, all PRs are required to pass automated security checks before being reviewed for merging. This PR has passed all automated checks:
Next step: Please share this PR link in our Telegram group so a maintainer can review and merge it: https://t.me/c/accesslayerorg/8514 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #403
#403 (sell proceeds estimate helper) was already implemented and merged via #419, but #419 targeted main instead of dev, so its closes tag never auto-closed the issue even though estimateSellProceeds is already on dev.
The helper shipped with no dedicated unit tests, so this adds that missing coverage rather than a no-op verification PR.
Changes
Test plan