Repository navigation
Play a slow frame after the buffer ran dry, not drop it as late - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the jitter buffer ran dry it concealed frames in place of ones that were only slow, and each of those, arriving after its concealed turn, counted as late and was dropped. Every frame after it came just as late, so one slow frame turned into a run of concealment and silence.
Now, when the buffer is empty and a frame arrives no older than what was concealed since it ran dry, it plays from its own time, a little later than due, and the frames after it follow on. A frame older than that is late as before.
A test covers a slow frame playing after two concealed turns, those after it following, and an older one still counted late.
+31 / −3 lines,
src/huddle_audio/jitter.rsonly.🤖 Generated with Claude Code