Repository navigation
Have the loopback test's window take its pictures as the real one does - #43
Merged
Merged
Conversation
Yannicked
added this pull request to stack #44
October 14, 2026 13:53
Yannicked
force-pushed
the
fix/loopback-test
branch
from
October 14, 2026 13:59
7e7b217 to
f94da4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #42.
loopback_session_joins_listens_and_leaves(ignored by default) failed on main with 1 share picture where it wants 5. Since be9e8c0 the decoders send a new picture only once the window has taken the last, and the test's pretend window never took the share's. It now takes the newest share and camera pictures every 30 ms while open, as the real one does each frame. Both loopback tests pass, four runs in a row.