Repository navigation
Keep secrets in a Secret newtype and derive Debug - #40
Merged
Merged
Conversation
Merged
Yannicked
added this pull request to stack #44
October 14, 2026 13:53
Teams token responses printed their tokens in Debug; they now can't.
Yannicked
force-pushed
the
refactor/secret-newtype
branch
from
October 14, 2026 13:59
7d9b9b1 to
4a3e994
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teams' token responses (
TokenResponse,AuthzTokens,AuthzResponse) andDeviceCodeResponse.device_codederivedDebugand would have printed their tokens; the log redaction misses Azure's opaque refresh tokens. Nothing logged them yet.redact::Secretis a string whoseDebugprints<redacted>, (de)serializes as the bare string and derefs to&str. With it,CommandderivesDebug(its 310-line hand-written one goes), and so doAppCredentials,AudienceToken,ConsumerToken,Meeting,ConnectionsOpen,AuthedUser,OauthAccess,TurnCredentials,Relay,MadeMeetingandSetCookie. Slack'sTokenandTeamsCredentialskeep their hand-writtenDebug: converting them touched 40+ sites for ~15 lines.Command'sDebugnow prints every non-secret field in full (an emoji upload's bytes, an edit's old message); nothing logs aCommand.+160 / −538 lines.