Repository navigation
pbkit: Fix rendering of + character - #794
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes address the rendering defect, with row-pattern verification supporting correct behavior and no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes + rendering in pbkit’s text renderer and preserves glyph strokes that reach the end of a row.
Changes:
- Adjusts the
+bitmap for better alignment. - Draws pending pixel runs after the row loop finishes.
| File | Description |
|---|---|
| lib/pbkit/pbkit_print.c | Updates the + glyph and fixes end-of-row stroke rendering. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At HEAD,
pb_draw_text_screen's rendering of the+character drops the horizontal bar, effectively becoming:.This change shifts the + character to be better aligned with other characters in the font and fixes the issue that was causing the horizontal bar to be dropped in the first place.
Note: technically we don't need to do both changes, each would fix it independently, but without the extra loop guard, glyphs that render against the end of the row would have the same issue.