Repository navigation
Conversation
Derive the widths, limits, and integer literal suffixes from the compiler's target type sizes. Add a compile-only C11 target with static assertions that check the widths, limits, and literal types against the ABI without linking the checks into tar. Fixes XayahSuSuSu#443
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Backups on 32-bit Android can fail when archive validation aborts, causing newly created archives to be treated as broken and deleted. Creating the icon archive can also fail with “memory exhausted.”
The bundled tar headers hard-code 64-bit widths and limits for size_t and ptrdiff_t, including when compiling for a 32-bit ABI. Those definitions give allocation checks limits that do not match the target types.
What this changes
Derive the widths, limits, and integer literal suffixes from the compiler's target type sizes. Add a compile-only C11 target with static assertions that check the widths, limits, and literal types against the ABI without linking the checks into tar.
How it was tested
Fixes #443