Repository navigation
Improve github actions ci build and runtime behavior - #409
Merged
linearcombination merged 7 commits intoNov 17, 2026
Merged
linearcombination merged 7 commits into
linearcombination merged 7 commits into
Conversation
Limit the total time that frontend tests can run as otherwise github actions ci can sometimes run up to their 6 hour max before they cancel it. There are various reasons why this can happen on github actions ci when it doesn't ever happen locally for the same tests. We don't want to wait around so long when it does happen. Better to fail "early", e.g., within 60 minutes
linearcombination
changed the base branch from
doc.bibleineverylanguage.org
to
doc-dev.walink.org
November 16, 2026 20:59
playwright.config.ts Since gh actions ci runs in Docker, we have to flag that so that it doesn't use too many resources. Locally we can still run tests, if desired, with npx playwright tests and in that case playwright.config.ts would yield CI false and thus would allow a more generous use of resources and concurrency on a local dev machine.
The frontend test step hit its 45-minute limit: the full Playwright suite runs serially (workers: 1) on a single runner alongside the whole stack. Workflow (docker-publish.yml): - Build each image once in a matrix job, save it as a tarball artifact, and docker load it in the test jobs instead of rebuilding it per job. - Give each image its own GHA cache scope; they previously shared the default scope and evicted each other's layers. - Split the frontend tests across 4 matrix shards, each on its own runner. - Run compose with --no-build --pull never so the timed step only runs tests. - Dump compose logs on test failure. - Cancel superseded runs on the same ref via a concurrency group. - Drop setup-qemu-action (no multi-platform builds) and remove github-env-vars-action from jobs that don't use CI_* vars. - Simplify the Push-Images condition to github.event_name == 'push'. - curl --fail on the deploy webhook. docker-compose.frontend-test.yml: - Pass PLAYWRIGHT_SHARD through to the test runner (defaults to 1/1). frontend/testsDockerfile: - Run `playwright test --shard="$PLAYWRIGHT_SHARD"`, defaulting to 1/1 so local runs still execute the full suite.
The first sharded run failed before any test started: `up --no-build --pull never` couldn't find doc-fileserver:latest (fileserver has only `build: ./web`, no image tag), and would next have failed on redis and mher/flower, which are pulled from Docker Hub. - Build fileserver in the image matrix, tagged doc-fileserver:latest (the <project>-<service> name compose expects), and load it in both test jobs. - Add an untimed "Prepare compose stack" step (`up --no-start`) that pulls redis/flower and builds anything still missing, so the timed step only starts containers and runs tests. - Drop --pull never from the test steps; keep --no-build so a missing image fails fast instead of building inside the 35-minute step.
Also updated some comments
PurpleGuitar
approved these changes
Nov 17, 2026
linearcombination
merged commit Nov 17, 2026
ad0f18a
into
WycliffeAssociates:doc-dev.walink.org
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #410
Problem
Frontend e2e tests were failing CI by hitting the 35-minute step limit.
The full Playwright suite ran serially (
workers: 1) on a single runneralongside the whole stack, and each test job also rebuilt every image.
All images shared one GHA cache scope, so they evicted each other's
layers and builds rarely hit the cache.
Changes
Builds
frontend-tests, fileserver) and pass it to test jobs as an artifact,
instead of rebuilding per job.
setup-qemu-action(no multi-platform builds) andgithub-env-vars-actionfrom jobs that don't useCI_*vars.Tests
PLAYWRIGHT_SHARD(
testsDockerfile+docker-compose.frontend-test.yml). Defaults to1/1, so local runs still execute the full suite.runs tests.
Other
curl --failon the deploy webhook.Results
Production / DevOps impact
None intended.
Push-Imagesbuilds and pushes the same images, tags andbuild args as before; the deploy webhook is unchanged. Changes are
limited to how images are built and tested in CI.
Notes for reviewers
45 min (previously unset). Tuned from observed durations plus some extra time to account for variations in backend API performance or github traffic loads/queueing.
doc-fileserver:latestrelies on the compose project namedoc(the checkout directory). Renaming the repo requires updating the tag.