chore(deps): pin saorsa-core to the copy-free send path - #35
Closed
mickvandijke wants to merge 1 commit into
Closed
mickvandijke wants to merge 1 commit into
mickvandijke wants to merge 1 commit into
Conversation
Picks up the copy-free message send path (saorsa-core e1f1ef92 with saorsa-transport 3bd451d2). No code changes in this crate. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
Author
|
Closing: this PR only bumps the saorsa-core git pin; the pin will be moved when the send-path changes (saorsa-transport #171, saorsa-core #166, ant-node #233) land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency pin only: saorsa-core → e1f1ef92 (
perf/replication-send-path), which frames and sends messages without copying the payload and carries saorsa-transport 3bd451d2. No code changes in this crate; it is the link that lets ant-node and ant-client consume a single copy of saorsa-core.Linear issue
Closes V2-TBD
Risk tier
Compatibility
Semver impact
Test evidence
cargo check --all-targetsandcargo test: 87 passed on the new pin.Testnet comparison, 2026-09-22 (this stack vs current
web-support). Two 60-node DigitalOcean fleets with an identical layout (8 regions, 18/60 nodes behind symmetric NAT), 4 native uploaders (50 MiB files, own wallets) + 1 continuous sha256-verified downloader each, started together and measured for 60 minutes. Baseline: ant-node50167d39+ ant-client04c64fa. New: ant-nodef55b7df8, saorsa-coree1f1ef92, saorsa-transport3bd451d2, ant-protocolac25b717, ant-clientf11c557(pins only, so the client code is identical on both sides).The baseline's warnings are the unbounded replication fan-out at work: 17,774 dial failures, 2,795 "Paid notify dropped at admission — paid-list evidence lost", 1,877 possession-probe timeouts, ~2,800 channel-send failures. The new stack logged no paid-notify drops, 134 dial failures and 286 probe timeouts. The 8% slower downloads on the new stack are the expected cost of deferring replication under load: every download fetched a file uploaded within the previous minute, which now has fewer replicas at that moment (
MAX_PENDING_FRESH_OFFERStrades memory for burst absorption). Raw data:ant-testnet/state/comparisons/web-support-send-path-vs-base-60m-0922/.New dependency
none
ADR
https://github.com/WithAutonomi/ant-node/blob/perf/replication-send-path/docs/adr/ADR-0016-bounded-fresh-offers-and-copy-free-sends.md
Mitigation / rollback
Revert the pin to saorsa-core 02dd65fc.
🤖 Generated with Claude Code