Skip to content

Patch T277832 - #90

Merged
jsnshrmn merged 5 commits into
masterfrom
theresnotime/T277832
Sep 9, 2026
Merged

Patch T277832#90
jsnshrmn merged 5 commits into
masterfrom
theresnotime/T277832

Conversation

@theresnotime

Copy link
Copy Markdown
Member

Bug: T277832

@jsnshrmn jsnshrmn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! The redaction logic looks good, but it also looks like a couple of paths got missed. Also, please separate the dependency work from the redaction work. short commit messages are the norm here, but it makes it even more important to try to keep each commit's scope tight.

Comment thread hashtagsv2/hashtags/views.py
Comment thread hashtagsv2/hashtags/views.py
Comment thread hashtagsv2/settings/base.py
@theresnotime
theresnotime marked this pull request as draft September 3, 2026 11:22
@theresnotime theresnotime changed the title Patch T277832, remove unsupported django-nose Patch T277832 Sep 3, 2026
@theresnotime

Copy link
Copy Markdown
Member Author

Thanks for your work on this! The redaction logic looks good, but it also looks like a couple of paths got missed.

The download pages now check the rows too, but they refuse a search with more than 5000 rows, because (e.g.) ?query=WPWP has 546,166 rows and one API call checks only 50. To make large downloads work again we must keep the visibility state in our own database, from the mediawiki.revision-visibility-change stream.

@theresnotime
theresnotime marked this pull request as ready for review September 3, 2026 12:02

@jsnshrmn jsnshrmn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! One inline question/suggestion.

Comment thread hashtagsv2/hashtags/visibility.py Outdated

@jsnshrmn jsnshrmn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

I noticed that hashtagsv2/graphs/views.py's top_user_statistics_data, users_csv, All_users_view, and projects_csv all call hashtag_queryset directly with no redact() call.

Comment thread hashtagsv2/hashtags/visibility.py
Comment thread hashtagsv2/hashtags/visibility.py Outdated
Comment thread hashtagsv2/hashtags/visibility.py
Comment thread hashtagsv2/hashtags/visibility.py Outdated
Comment thread hashtagsv2/hashtags/visibility.py
Comment thread hashtagsv2/hashtags/views.py Outdated
Comment thread hashtagsv2/hashtags/views.py Outdated
@jsnshrmn
jsnshrmn force-pushed the theresnotime/T277832 branch from 2eab6b0 to 6b14790 Compare September 9, 2026 20:36

@jsnshrmn jsnshrmn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; Note that I rebased, then munged the the commits related to django nose for cleanliness and speed.

@jsnshrmn
jsnshrmn merged commit 49be61d into master Sep 9, 2026
2 checks passed
@jsnshrmn
jsnshrmn deleted the theresnotime/T277832 branch September 9, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants