Simplify WASM_UNREACHABLE. NFC - #8976
Merged
Merged
Conversation
sbc100
requested review from
kripken and
tlively
and removed request for
a team
August 6, 2026 19:27
kripken
approved these changes
Aug 6, 2026
sbc100
enabled auto-merge (squash)
August 6, 2026 20:10
The `WASM_BUILTIN_UNREACHABLE` macro is unconditionally defined in `compiler-support.h` so checking here is redundant.
sbc100
force-pushed
the
WASM_BUILTIN_UNREACHABLE
branch
from
August 20, 2026 18:56
8c928b4 to
11f6a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
WASM_BUILTIN_UNREACHABLEmacro is unconditionally defined incompiler-support.hso checking here is redundant.