VBoxTpG: derive the VTG object UUID from the script - #827
Open
bmwiedemann wants to merge 1 commit into
Open
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
Bot
added
the
OCA Required
The UUID identifies the tracepoint data of a module, but there is no need for it to be random: a fresh one on every run makes VBoxDD.so, VBoxRT.so, VBoxVMM.so, VBoxSVC etc differ between two builds of the same sources. Hash a fixed namespace UUID, the script name, the code generation options and the script content into a name-based (RFC-4122 version 3) UUID instead, which keeps the tracepoint data of different modules apart and is stable across rebuilds. Neither the script path nor the output and temporary file names are hashed, as those depend on where the tree is being built. Modules generated from the same script with the same options do end up with the same UUID now. That is what VTGOBJHDR::Uuid is there for - supdrvVtgFindObjectCopy() uses it to share a single ring-0 copy of the data, comparing the rest of the header before doing so. See https://reproducible-builds.org/ for why this is good. This patch was done while working on reproducible builds for openSUSE. Signed-off-by: Bernhard M. Wiedemann <oraclebmw@lsmod.de>
|
Thank you for signing the OCA. |
oracle-contributor-agreement
Bot
added
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UUID identifies the tracepoint data of a module, so it has to differ between modules, but there is no need for it to be random: a fresh one on every run makes
VBoxDD.so, VBoxRT.so, VBoxVMM.so, VBoxSVCetc differ between two builds of the same sources.Hash the script name and its content into a name-based (RFC-4122 version 3) UUID instead, which keeps it unique per module and stable across rebuilds.
See https://reproducible-builds.org/ for why this is good.
This patch was done while working on reproducible builds for openSUSE.