fix(fake): remove duplicate read_zone_conf that shadowed the working implementation - #218
Open
TomaszSwierszczCA wants to merge 1 commit into
Open
Conversation
…impl FakeConnection defined read_zone_conf twice; Python keeps the later definition, so the bare `raise NotImplementedError` stub shadowed the working implementation. Any test_mode (fake-backend) enrollment that reads the zone config first - as the ansible collection does - failed with NotImplementedError. Delete the duplicate stub so the real read_zone_conf (returning a populated ZoneConfig) is used. Adds offline regression tests covering read_zone_conf and the full fake enroll flow. Offline suite: 57 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FakeConnection defined read_zone_conf twice; Python keeps the later definition, so the bare
raise NotImplementedErrorstub shadowed the working implementation. Any test_mode (fake-backend) enrollment that reads the zone config first - as the ansible collection does - failed with NotImplementedError.Delete the duplicate stub so the real read_zone_conf (returning a populated ZoneConfig) is used. Adds offline regression tests covering read_zone_conf and the full fake enroll flow. Offline suite: 57 passed.