fix(ngts): enable service-generated CSR enrollment on CIT-only zones [VC-59232] - #215
Open
TomaszSwierszczCA wants to merge 1 commit into
Open
fix(ngts): enable service-generated CSR enrollment on CIT-only zones [VC-59232]#215TomaszSwierszczCA wants to merge 1 commit into
TomaszSwierszczCA wants to merge 1 commit into
Conversation
…[VC-59232] NGTS + csr_origin=service failed with "the zone format is incorrect" on a bare CIT alias (local CSR worked). Root cause: NGTS overrode public get_policy but not private _get_policy, so the inherited service-CSR builder hit Cloud's zone backslash-split and Application-owner resolution — both invalid for NGTS. - Override private _get_policy(zone, subject_cn_to_str) in NGTSConnection: resolve the CIT via the CIT-only path, no owner resolution (Go GetPolicy / GetPolicyWithRegex parity). Public get_policy passes True, service path False. - _retrieve_service_generated_cert: encode key_password to bytes (None -> b"") so SealedBox.encrypt no longer raises TypeError; fixes Cloud/VaaS retrieve too. - Service-CSR SANs: emit each type independently instead of gating on san_dns, which silently dropped IP/email/URI-only SANs (Go getCsrAttributes parity). Verified live end-to-end against an NGTS tenant; offline suite green (60) + bandit clean. Tests added/hardened in tests/test_local_methods.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NGTS + csr_origin=service failed with "the zone format is incorrect" on a bare CIT alias (local CSR worked). Root cause: NGTS overrode public get_policy but not private _get_policy, so the inherited service-CSR builder hit Cloud's zone backslash-split and Application-owner resolution — both invalid for NGTS.
Verified live end-to-end against an NGTS tenant; offline suite green (60) + bandit clean. Tests added/hardened in tests/test_local_methods.py.