Repository navigation
consensus_sim: pin no-contest fee case to before HF16 - #216
Merged
Merged
Conversation
pm_no_contest_fee_three_states derived its virtual start from fc::time_point::now(). After 2026-10-31T00:00:00Z that start is past the HF16 activation time, so process_hardforks applied HF15 at block 15 and HF16 at block 16 during setup: market 0, meant to be announced BEFORE the fork, was announced under it and came out frozen. Master CI (run 41149337768, 1 of 173) failed with frozen=true, fee=1u and insurance delta 2u instead of the expected 9u — the same wall-clock trap pm_lifecycle_start() was pinned for. Pin the start two days before CHAIN_HARDFORK_16_TIME (after HF15, before HF16, room for the settle grace), keeping the existing HF14 clamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master CI went red right after the HF16 activation: run 41149337768, job
Testnet config + consensus_sim (1 validators), 1 of 173 cases —pm_no_contest_fee_three_states, 4 assertions.Cause. The case derived its virtual start from
fc::time_point::now(). From 2026-10-31T00:00:00Z on, that start is already past the HF16 activation time, soprocess_hardforksapplied HF15 at block 15 and HF16 at block 16 during setup (visible in the job log). Market 0 — "announced BEFORE the fork" — was therefore announced under the fork and frozen:This is exactly the wall-clock trap
pm_lifecycle_start()was pinned for;test_pm_no_contest_fee.cppwas added later and keptnow().Fix. Pin the start two days before
CHAIN_HARDFORK_16_TIME— after HF15, before HF16, room for the settle grace window — keeping the existing HF14 clamp. Both bounds are compile-time constants, so the pair stays ordered at any real date.Note: the original goal this run was the HF16 acceptance gate, and that part is fine — 0 occurrences of
No QC for headacross 173 cases. This PR only removes the unrelated red.🤖 Generated with Claude Code