Repository navigation
HF16 follow-ups: zh-CN readiness, quorum wording, schedule comments - #194
Merged
Merged
Conversation
…doc; chain: correct next_shuffle_block_num comments Comment-only in chain code: next_shuffle_block_num is write-only, the schedule (and the emergency hybrid override) is rebuilt when head % 21 == 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #191. Docs and comments only; no compiled behaviour changes.
@l10n/zh-CN/docs/consensus/hf16.md: adds the "检查就绪状态" section (it had none), matching en/ru after HF16 readiness: count the quorum by schedule slots #191. Uses the existing zh terms (调度槽位, 签名密钥, 空密钥, 洗牌, 紧急共识).docs/prediction-markets/pm-no-contest-fee-freeze.md+ ru: "17 of 21 validators must run the 4.2.0 binary" was the same wrong metric as snapshot: restore PM seed flags; docs: HF16 readiness check #184. It now reads 17 schedule slots voting 4.2.0 and points toscripts/hardfork_readiness.py. The zh-CN copy is a summary that already links to HF16, so it is unchanged.database.cppemergency branch +validator_objects.hpp: the comments said the hybrid override waits fornext_shuffle_block_num. Nothing reads that field; the schedule is rebuilt whenhead % (CHAIN_MAX_VALIDATORS * REPEAT) == 0(raised by On1x on HF16 readiness: count the quorum by schedule slots #191). The assignment stays, because it is object state.