Repository navigation
Conversation
Bumps thirdparty/fc to 3968605 (branch fix/log-rotation-timer-thread): the file appender used to schedule rotations on the fc fiber queue of the thread that built it, and vizd never services that queue after startup, so the hourly files stopped after the first one (measured 2026-10-20: one 37 MB file in 9 h on testnet, no new hourly files in 4 days on mainnet). Docs (en, ru, zh-CN) now state that rotation is serviced by the appender's own thread and that binaries built before 2026-10-25 still need external logrotate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file appender used to schedule the next rotation with
fc::async/fc::scheduleon thefiber queue of the thread that constructed it.
vizdbuilds its loggers inmain()and thenlives in
boost::asio::io_context::run(), so that queue is never serviced again: the initialrotation ran, the next task sat forever, and the node kept writing into a single file (measured
2026-10-20: 37 MB in 9 h on testnet, no new hourly file in 4 days on mainnet). While there,
_current_file_start_timewas not updated in the "same hour" branch either.Bumps
thirdparty/fcto VIZ-Blockchain/fc@3968605 (merged into fc master): rotation is nowserviced by a dedicated
std::thread(same approach as the snapshot plugin) —start()performs the initial rotation synchronously, the timer sleeps in <=1 s slices until the next
boundary, shutdown joins the thread, and timer exceptions back off 1 s instead of terminating
or spinning.
_current_file_start_timeis written underslock.No consensus impact: this is logging infrastructure only.
Verification (container on the project's boost-base-1.91 image, harness with main-thread
sleeps, i.e. the same threading picture as
io_context::run()):Docs updated on all three locales: rotation is now serviced by the appender's own thread, and
binaries built before 2026-10-25 still need external logrotate.