Add test for hook pps_ts - #1053
Open
windrad6 wants to merge 85 commits into
Open
Conversation
Signed-off-by: Manuel <post@cl0.de>
Signed-off-by: Manuel <post@cl0.de>
windrad6
force-pushed
the
hook-pps-ts-tests
branch
from
September 4, 2026 12:43
6b6165e to
1f577b8
Compare
Signed-off-by: Manuel <post@cl0.de>
pjungkamp
reviewed
Sep 4, 2026
Signed-off-by: Manuel <post@cl0.de>
windrad6
force-pushed
the
hook-pps-ts-tests
branch
from
September 4, 2026 17:49
4930339 to
469f54c
Compare
windrad6
marked this pull request as ready for review
September 6, 2026 10:50
windrad6
enabled auto-merge (rebase)
September 6, 2026 10:50
Contributor
|
After merging @pjungkamp changes of the config validation, this PR unfortunately has now conflicts. |
…onfig selection Signed-off-by: Manuel <post@cl0.de>
The LWS_CALLBACK_CLOSED handler set the connection state to CLOSED and then compared the (now always CLOSED) state against CLOSING, making the check dead code. Save the state before overwriting it so the intended reconnect logic can actually trigger. Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
The details string contained 'in.epoch=' twice: once for the epoch mode name and once for the numeric epoch value. Rename the second occurrence to 'in.epoch_value'. Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
strcpy() into the fixed-size sun_path buffer could overflow for long socket paths. Use strncpy() and force NUL termination. Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
strcpy() into the fixed-size ifr_name (IFNAMSIZ) buffer could overflow for long interface names. Use strncpy() and force NUL termination. Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Two 's: b s: b' pairs lacked the separating comma, causing jansson to mis-parse the format and silently drop some path status fields from the API/websocket status output. Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Rename 'curentPos' to 'currentPos'. Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
The original code overwrote *dest with the result of realloc() without checking for NULL, leaking the old buffer and then copying into a NULL pointer. Also handle vasprintf() failure. On allocation failure the old buffer is preserved and returned unchanged. Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Rename requests/capabiltities.cpp to requests/capabilities.cpp and fix the 'capabiltities'/'ressource' misspellings in its comment and API description string (visible in the API index). Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Three issues in the Python Node client:
- config={} was a mutable default argument; use None and create a dict.
- The api_url deduction read the 'config' parameter instead of
self.config, ignoring a config loaded from config_filename.
- self.child was only created in start(), so is_running() before start()
raised AttributeError; initialize it to None.
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de> Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
…ation Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Manuel <post@cl0.de>
Signed-off-by: Manuel <37443948+windrad6@users.noreply.github.com>
windrad6
force-pushed
the
hook-pps-ts-tests
branch
from
September 13, 2026 11:25
c9e1766 to
956899c
Compare
Contributor
Author
Fixed the conflicts. |
Contributor
|
@windrad6 Could you rebase this to the latest master? This PR contains 85 commits.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test for the pps_ts hook
Update the way timetags are caluclated in the hook
Add option to use the incoming sample time tag instead of CLOCK_REALTIME