Keep workspace-write access on cross-session MCP resume - #2099
Merged
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a model calls
resumefrom a different MCP session than the one that started the execution (for example after an mcp-remote reconnect), the requester's session forwards the resume to the owning session viaresumeExecutionForModel. That RPC ranengine.resumewith noCurrentOrgWriteAccessbound, so the engine rebound the paused execution to the fail-closed"denied"default. An admin's pendingaddServer/addSpec/updateSpecthen failed withorg_write_denied.McpModelResumeCaller) now carries the requester'sorgWriteAccess, read from its own request context.engine.resume. A caller from the previous deploy that omits it is treated as denied.Prod telemetry over the last 14 days: every always-gated admin write resumed through the cross-session path was denied. Same-session resumes were almost never denied.
Tests: new cases in
agent-session-model-resume.test.tscover allowed, denied, and a legacy caller. The allowed case fails without the fix. Typecheck is clean for@executor-js/cloudflare,apps/cloud, andapps/host-cloudflare.