Use saved OAuth apps for MCP connections - #2069
Draft
RhysSullivan wants to merge 4 commits into
Draft
RhysSullivan wants to merge 4 commits into
RhysSullivan wants to merge 4 commits into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 262c76c | Sep 18 2026, 08:48 PM |
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 262c76c | Commit Preview URL Branch Preview URL |
Sep 18 2026, 08:46 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connect can register another OAuth app even when a suitable app is already saved. Reuse the app linked to the MCP integration, or one whose exact endpoints and resource match discovery. Preserve the app’s integration in the API response and keep the app owner separate from the connection owner.
The recording uses the same synthetic setup and one Connect click. Before, provider consent names the newly registered Executor app. After, it names the existing Saved app. Browser trace frames are aligned at Connect; the consent view is enlarged and its final frame held.
Validation: 91 unit tests pass. Both saved-app browser cases pass through consent and persistence on self-host, with the existing client ID, a personal connection, and no new registration. The default-tab check passes after waiting for async selection. The resource-indicator regression also passes, including omitted resource parameters and an empty field after reopening the saved app. React, API, and e2e type checks, lint, and formatting pass.
The published MCP emulator form omits its selected username, so the fixture forwards that username in the real form POST. Provider responses and the token exchange are not mocked. Chrome independently verified the existing client ID and consent page. Local cloud startup timed out; cloud coverage and release gates are running in CI.