Repository navigation
fix(studio-pack): run the oracle studio-pack.sh from inside its worktree - #2
Merged
Merged
Conversation
scripts/orch/gr mounts the git top-level of the current directory (gr:8), while studio.sh resolves its root from the script's own path (studio.sh:23). Invoked from the main checkout, the oracle compiled main's tree into the checkout's target/ and then failed to copy the wasm from the worktree's (run 37690199241: cp: cannot stat).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the first
studio-packdispatch, which failed:https://github.com/Univers42/graph_render/actions/runs/37690199241.
It failed at "Byte-identical to the commit's own studio-pack.sh", exit 2:
Nothing was pushed. The tag check, the two Dockerfile builds and their comparison all passed; Push was skipped.
Root cause
scripts/orch/gr:8decides what to mount at/wwithtop=$(git rev-parse --show-toplevel), so it uses the git top-level of the current directory (gr:21,-v "$top:/w").scripts/studio.sh:23instead resolvesrootfrom the script's directory.$GITHUB_WORKSPACE, the main checkout. So cargo compiled main's tree into the checkout'starget/, andstudio.shthen looked for the wasm in the 77b68d9 worktree's emptytarget/.Fix (one line)
Evidence (local, step body extracted verbatim from the workflow, run with
bash --noprofile --norc -eo pipefailfrom the main checkout)cp: cannot stat '…/upstream/target/wasm32-unknown-unknown/release/graph_wasm.wasm'. The wasm landed in the main checkout'starget/diff -ragainst the Dockerfile pack. Upstream tarball sha25644f8f241…c024, the same as the PR #1 evidence. The main checkout has notarget/Merge policy: merge commit (
--merge), branch deleted after merge.