docs: couple of bugs + style pass on affected pages - #4167
Open
jabbacakes wants to merge 2 commits into
Open
jabbacakes wants to merge 2 commits into
jabbacakes wants to merge 2 commits into
Conversation
|
Check the configuration's TOML syntax, permitted settings, and size limit. See the error below. Error message: Configuration content:# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/
[github_app]
handle_pr_actions = ['opened', 'ready_for_review'] # PR events that auto-run pr_commands
pr_commands = ["/harness-review"] # what runs on those events
reviewer_commands = ["/harness-review"] # what runs when @u-pr is added as reviewer
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-3.x.x #4167 +/- ##
==============================================
Coverage 78.19% 78.19%
==============================================
Files 153 153
Lines 26272 26272
==============================================
Hits 20544 20544
Misses 5728 5728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Addressing a couple of doc feedback tickets we got from users, plus a style pass on the affected pages. Changes specific to the bug fixes are as follows:
object-spawning.mdupdates to samples so that they compile. Some of these were casing errors (that I think I might have introduced a while ago 🙈), addingusingto samples so they compile if directly copied and pasted, and other minor tweaks. Ctrl+f for ``` codeblock fencing for a quick review of these changes.networktime-ticks.mdchanges on lines 9 and 13 to clarifyLocalTimebehaviour. The updates toNetworkTimeSystem.csare matching updates in the API docs.Jira ticket
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Built locally to verify changes
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Up-port
N/A
Backports
N/A small docs bug fixes only, we don't generally backport those unless they're major