Skip to content

docs: couple of bugs + style pass on affected pages - #4167

Open
jabbacakes wants to merge 2 commits into
develop-3.x.xfrom
docs-bugs
Open

jabbacakes wants to merge 2 commits into
develop-3.x.xfrom
docs-bugs

Conversation

@jabbacakes

Copy link
Copy Markdown
Contributor

Purpose of this PR

Addressing a couple of doc feedback tickets we got from users, plus a style pass on the affected pages. Changes specific to the bug fixes are as follows:

  • DOCMP-1732: object-spawning.md updates to samples so that they compile. Some of these were casing errors (that I think I might have introduced a while ago 🙈), adding using to samples so they compile if directly copied and pasted, and other minor tweaks. Ctrl+f for ``` codeblock fencing for a quick review of these changes.
  • DOCMP-1728: networktime-ticks.md changes on lines 9 and 13 to clarify LocalTime behaviour. The updates to NetworkTimeSystem.cs are matching updates in the API docs.

Jira ticket

Documentation

  • Includes edits to existing public manual documentation.
  • Includes edits to existing public API documentation.

Testing & QA (How your changes can be verified during release Playtest)

Built locally to verify changes

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

N/A

Backports

N/A small docs bug fixes only, we don't generally backport those unless they're major

@jabbacakes
jabbacakes requested a review from a team as a code owner September 22, 2026 10:07
@u-pr

u-pr Bot commented Sep 22, 2026

Copy link
Copy Markdown

⚠️ Some settings were ignored in '.pr_agent.toml (repository root)' repo settings

Check the configuration's TOML syntax, permitted settings, and size limit. See the error below.


Error message:
Ignored prohibited settings: github_app.handle_pr_actions. Permitted settings were applied.

Configuration content:
# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/

[github_app]
handle_pr_actions = ['opened', 'ready_for_review']  # PR events that auto-run pr_commands
pr_commands       = ["/harness-review"]             # what runs on those events
reviewer_commands = ["/harness-review"]             # what runs when @u-pr is added as reviewer

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Needs changes

The timing correction and updated API references align with the implementation, but the revised spawning guidance still misstates object lifecycle behavior.

Reviewed commit 6dfdb78

🤖 Helpful? 👍/👎

Comment thread com.unity.netcode.gameobjects/Documentation~/basics/object-spawning.md Outdated
Comment thread com.unity.netcode.gameobjects/Documentation~/basics/object-spawning.md Outdated
@codecov-github-com

codecov-github-com Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@              Coverage Diff               @@
##           develop-3.x.x    #4167   +/-   ##
==============================================
  Coverage          78.19%   78.19%           
==============================================
  Files                153      153           
  Lines              26272    26272           
==============================================
  Hits               20544    20544           
  Misses              5728     5728           
Flag Coverage Δ
NGOv2_project_testproject_ubuntu 76.64% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...de.gameobjects/Runtime/Timing/NetworkTimeSystem.cs 95.04% <ø> (ø)
Components Coverage Δ
com.unity.netcode.gameobjects 78.19% <ø> (ø)

ℹ️ Need help interpreting these results?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant