Skip to content

docs(liquidity-launchpad): list CCA factory v2.1.0 chains and CCALens - #1182

Open
ninglinLiu wants to merge 1 commit into
Uniswap:mainfrom
ninglinLiu:fix/1151-cca-factory-chains
Open

ninglinLiu wants to merge 1 commit into
Uniswap:mainfrom
ninglinLiu:fix/1151-cca-factory-chains

Conversation

@ninglinLiu

Copy link
Copy Markdown

Summary

Fixes #1151.

The Liquidity Launchpad deployments page listed only the v2.0.0 ContinuousClearingAuctionFactory and said it was on "all currently supported chains" without naming Avalanche C-Chain, X Layer, or Ink. That disagreed with continuous-clearing-auction's README, which recommends v2.1.0 at 0x000000001F26a0044BaA66024e7b6599c61963F8, and with on-chain reality.

Changes

  • Add the recommended v2.1.0 factory address (and fill the missing v2.0.0 commit hash).
  • Explicitly list chains where v2.1.0 has code: Ethereum, Unichain, Base, Arbitrum, Avalanche C-Chain (43114), X Layer (196), Ink (57073), and Sepolia — verified with eth_getCode.
  • Add a CCALens table (0xc3C65F5453A3674aDb693cbdA3C842545cD30f53), verified on Ethereum, Avalanche, and X Layer (no code on Ink).

Constructor-parameter wording for the factory is already covered by #1150; this PR does not touch that sentence beyond replacing the chain-list paragraph.

Verification

FACTORY=0x000000001F26a0044BaA66024e7b6599c61963F8
for rpc in https://ethereum-rpc.publicnode.com https://api.avax.network/ext/bc/C/rpc https://rpc.xlayer.tech https://rpc-gel.inkonchain.com; do
  curl -s -X POST "$rpc" -H 'Content-Type: application/json' \
    -d "{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"eth_getCode\",\"params\":[\"$FACTORY\",\"latest\"]}"
done

Each of those returns non-empty bytecode.

Fixes Uniswap#1151

The deployments page only listed the v2.0.0 factory and said it was on
"all currently supported chains" without naming Avalanche, X Layer, or
Ink. Align with continuous-clearing-auction's README: add the recommended
v2.1.0 factory address (verified via eth_getCode on those chains) and a
CCALens table.
@github-actions

Copy link
Copy Markdown

Thanks for contributing to Uniswap Docs! 🦄

Quick heads up on how this repo works: the docs you see on developers.uniswap.org are built from a separate source repo. When we accept a change here, we port it over there, so your fix might show up on the live site before it lands in this repo.

Updates to this repo come in batches on a regular cadence. When yours is included, you'll be credited as a co-author on the commit, so the contribution counts on your GitHub profile and in Uniswap/docs.

We review every PR but can't merge everything. Either way, someone from the docs team will follow up here once we've taken a look.

One legal bit: by submitting a PR you agree your contribution is licensed under the repo's MIT license.

Comment on lines +13 to +14
| 0x000000001F26a0044BaA66024e7b6599c61963F8 | 7d7602d257733315434570f2a0c2f94f1c7b207a | v2.1.0 |
| 0x00cCa200BF124dBfA848937c553864f4B4CE0632 | aee9bca51c92c24eb24a00d75ad98e678bac61d3 | v2.0.0 |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New contract address (0x000000001F26a0044BaA66024e7b6599c61963F8 for v2.1.0) and a newly-filled-in commit hash for v2.0.0 (aee9bca51c92c24eb24a00d75ad98e678bac61d3). These match the PR description's eth_getCode verification, but please have someone with access to the continuous-clearing-auction repo/deployment records confirm the address and commit SHAs independently before merging — I wasn't able to query GitHub or an RPC endpoint from this review environment to verify them myself.


| Address | Commit Hash | Version |
| ------------------------------------------ | ---------------------------------------- | ------- |
| 0xc3C65F5453A3674aDb693cbdA3C842545cD30f53 | aee9bca51c92c24eb24a00d75ad98e678bac61d3 | v2.0.0 |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New CCALens contract address 0xc3C65F5453A3674aDb693cbdA3C842545cD30f53. Note it's listed with the exact same commit hash (aee9bca51c92c24eb24a00d75ad98e678bac61d3) as the v2.0.0 ContinuousClearingAuctionFactory row above — plausible if both were added/released in the same commit, but worth a quick double-check that this wasn't copy-pasted from the wrong row, since this address/hash pair couldn't be independently verified from this review environment.

@github-actions

Copy link
Copy Markdown

Review summary

Content-only change to content/liquidity/liquidity-launchpad/deployments.mdx: adds the v2.1.0 ContinuousClearingAuctionFactory address, backfills the previously-missing v2.0.0 commit hash, lists the specific chains (with correct chain IDs: Avalanche C-Chain 43114, X Layer 196, Ink 57073) where v2.1.0 has code, and adds a new CCALens section/table.

  • MDX/formatting: Tables and frontmatter are well-formed, markdown renders correctly, no broken anchors.
  • Internal consistency: Replaced the vague "all currently supported chains" claim with an explicit, verifiable chain list — matches the PR description's eth_getCode verification. No other doc pages reference the old wording, so nothing else needs updating.
  • Links: The new CCALens.sol GitHub link and existing CHANGELOG links look correctly formed.
  • Contract addresses/commit hashes (flagged for human verification): Per review policy, any new/changed address or hash needs a second pair of eyes — I left two inline comments:
    1. New v2.1.0 factory address + newly-added v2.0.0 commit hash.
    2. New CCALens address/commit hash, which happens to share its commit hash with the v2.0.0 factory row — plausible (same release commit) but worth a quick sanity check.

I wasn't able to independently query GitHub or an RPC endpoint from this review environment, so these should be confirmed by someone with direct access before merging. Nothing else stood out — no spam/promotional content, grammar reads fine.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs issue]: CCA factory not listed on Avalanche, X Layer or Ink (page and deployments.json)

1 participant