Skip to content

docs(sdks): fix dead MetaMask, Recharts and Electisec links in SDK guides - #1178

Open
ninglinLiu wants to merge 1 commit into
Uniswap:mainfrom
ninglinLiu:docs/fix-dead-sdk-guide-links
Open

ninglinLiu wants to merge 1 commit into
Uniswap:mainfrom
ninglinLiu:docs/fix-dead-sdk-guide-links

Conversation

@ninglinLiu

Copy link
Copy Markdown

Summary

Fixes four dead external links in the SDK guides (all currently return 404):

Page Old link (404) New link
SDK v3 → Swapping (local network setup) support.metamask.io/hc/en-us/articles/360043227612-How-to-add-a-custom-network-RPC support.metamask.io/networks-and-sidechains/managing-networks/how-to-add-a-custom-network-rpc/ ("How to add a network")
SDK v3 → Swapping (importing tokens) support.metamask.io/hc/en-us/articles/360015489031-How-to-display-tokens-in-MetaMask support.metamask.io/manage-crypto/tokens/how-to-display-tokens-in-metamask/ ("How to display tokens in MetaMask")
SDK v3 → Active Liquidity recharts.org/en-US/ recharts.org/ (same as the link already used at the bottom of that page)
SDK v4 → Position Minting (SWEEP note) reports.electisec.com/reports/04-2025-Sickle#2-high---... reports.electisec.com/04-2025-Sickle#2-high---... (the Electisec reports site dropped the /reports/ prefix; same report, anchor unchanged)

MetaMask moved its help center off the old Zendesk /hc/en-us/articles/... URLs.

Type of change

  • Fix (typo, broken link, incorrect or outdated content)
  • New content (guide, page, code example)
  • Update to existing content
  • Other

How has this been verified?

  • curl -L returns 404 for all four old URLs and 200 for the new ones; checked each new page shows the same content (MetaMask "How to add a network" / "How to display tokens in MetaMask", the Recharts home page, and the Electisec "Sickle Uniswap and Curve integrations Review" containing "2. High - UniswapV4Connector.addLiquidity() does not reclaim excess ETH").

Anything else reviewers should know?

Docs-only, 4 lines in 3 files. Separate from #1173–#1177. Prepared with AI assistance; I reviewed the change and checked every link listed above.

@github-actions

Copy link
Copy Markdown

Thanks for contributing to Uniswap Docs! 🦄

Quick heads up on how this repo works: the docs you see on developers.uniswap.org are built from a separate source repo. When we accept a change here, we port it over there, so your fix might show up on the live site before it lands in this repo.

Updates to this repo come in batches on a regular cadence. When yours is included, you'll be credited as a co-author on the commit, so the contribution counts on your GitHub profile and in Uniswap/docs.

We review every PR but can't merge everything. Either way, someone from the docs team will follow up here once we've taken a look.

One legal bit: by submitting a PR you agree your contribution is licensed under the repo's MIT license.

@github-actions

Copy link
Copy Markdown

Review summary

Reviewed the diff (gh pr diff 1178) — 3 files, 4 link changes, all dead-link fixes.

Verified against repo:

  • All 4 old URLs being replaced are the only occurrences of those exact dead links in content/, and each matches precisely what's in the diff — no missed instances elsewhere.
  • The recharts.org fix makes active-liquidity.mdx line 22 consistent with the existing https://recharts.org/ link already used later in the same file (line 290), confirming the PR description's claim.
  • No contract addresses, chain IDs, or code samples are touched — this is a pure Markdown link-text/URL change.
  • MDX syntax is unaffected; link format ([text](url)) is preserved correctly in all four edits.

Not independently verified: I don't have live network access in this review environment, so I could not personally curl the four new URLs to confirm 200 status. The PR description states the author verified all four old links 404 and all four new links 200, with content spot-checks. The new URL patterns (MetaMask's current help-center path structure, Electisec's report path without /reports/) are consistent with known site restructurings, which supports the author's claims.

Verdict: Looks good — minimal, well-scoped, docs-only link fix. No issues found. Human spot-check of the 4 live URLs recommended before merge per standard practice, but nothing here is blocking.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant