Repository navigation
docs(sdks): fix dead MetaMask, Recharts and Electisec links in SDK guides - #1178
ninglinLiu wants to merge 1 commit into
Conversation
|
Thanks for contributing to Uniswap Docs! 🦄 Quick heads up on how this repo works: the docs you see on developers.uniswap.org are built from a separate source repo. When we accept a change here, we port it over there, so your fix might show up on the live site before it lands in this repo. Updates to this repo come in batches on a regular cadence. When yours is included, you'll be credited as a co-author on the commit, so the contribution counts on your GitHub profile and in Uniswap/docs. We review every PR but can't merge everything. Either way, someone from the docs team will follow up here once we've taken a look. One legal bit: by submitting a PR you agree your contribution is licensed under the repo's MIT license. |
Review summaryReviewed the diff ( Verified against repo:
Not independently verified: I don't have live network access in this review environment, so I could not personally Verdict: Looks good — minimal, well-scoped, docs-only link fix. No issues found. Human spot-check of the 4 live URLs recommended before merge per standard practice, but nothing here is blocking. |
Summary
Fixes four dead external links in the SDK guides (all currently return 404):
support.metamask.io/hc/en-us/articles/360043227612-How-to-add-a-custom-network-RPCsupport.metamask.io/networks-and-sidechains/managing-networks/how-to-add-a-custom-network-rpc/("How to add a network")support.metamask.io/hc/en-us/articles/360015489031-How-to-display-tokens-in-MetaMasksupport.metamask.io/manage-crypto/tokens/how-to-display-tokens-in-metamask/("How to display tokens in MetaMask")recharts.org/en-US/recharts.org/(same as the link already used at the bottom of that page)reports.electisec.com/reports/04-2025-Sickle#2-high---...reports.electisec.com/04-2025-Sickle#2-high---...(the Electisec reports site dropped the/reports/prefix; same report, anchor unchanged)MetaMask moved its help center off the old Zendesk
/hc/en-us/articles/...URLs.Type of change
How has this been verified?
curl -Lreturns 404 for all four old URLs and 200 for the new ones; checked each new page shows the same content (MetaMask "How to add a network" / "How to display tokens in MetaMask", the Recharts home page, and the Electisec "Sickle Uniswap and Curve integrations Review" containing "2. High - UniswapV4Connector.addLiquidity() does not reclaim excess ETH").Anything else reviewers should know?
Docs-only, 4 lines in 3 files. Separate from #1173–#1177. Prepared with AI assistance; I reviewed the change and checked every link listed above.