Repository navigation
Fix TRUST_USERNAME test harness: trust iauth username, not force tilde - #96
Merged
Merged
Conversation
Replace the shared iauth-tilded stub with a temporary trusted-U helper for Cloudflare websocket coverage, drop permanent IAuth from docker configs, and give ident-bound registration tests enough time to finish. Co-authored-by: Cursor <cursoragent@cursor.com>
- Enable ident lookups on leaf1 so leaf users are tilded, and assert the
tilde before hiding in test_remote_leaf_user_hidden_via_services (the
test passed vacuously without it).
- iauth-trust-username.pl: reply only to U, send D only after both USER
and NICK are seen (D could otherwise beat the U reply), report a V
version so tests can wait for the policy after REHASH.
- CF websocket tests: wait for the iauth stub via STATS iauthconf, reload
the hub config once on restore (finalizer is now fallback-only), drop
the unused oper from the tilde test and guard it against a live IAuth.
- Wording: any username component (even empty) enables DoIdentLookups;
clarify cidr test deadline comment; revert no-op {exc!s}.
Ratler
force-pushed
the
fix/trustusername-tests
branch
from
October 4, 2026 16:49
8a1fbd2 to
513aac9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the shared iauth-tilded stub with a temporary trusted-U helper for Cloudflare websocket coverage, drop permanent IAuth from docker configs, and give ident-bound registration tests enough time to finish.