Conversation
github-actions
Bot
added
test:uipath-langchain
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new wire DTO and non-abstract proxy method lack contract tests, and the acknowledged package version bump remains outstanding.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Mirrors the user access-token operation in the Python job API IPC contract.
Changes:
- Adds the token request DTO with optional scopes.
- Adds non-abstract
GetUserAccessTokenforwarding.
| File | Description |
|---|---|
packages/uipath/src/uipath/_cli/_job_api.py |
Extends the IPC contract for user access tokens. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| class PythonUserAccessTokenRequestDto: | ||
| """A token request; field names are the wire keys (do not rename).""" | ||
|
|
||
| jobKey: str | ||
| resumeVersion: int | None = None | ||
| scopes: str | None = None |
| async def GetUserAccessToken(self, request: PythonUserAccessTokenRequestDto) -> str: | ||
| """Request a user access token for the job; empty scopes means the job's default scopes.""" | ||
| raise NotImplementedError |
🚨 Heads up:
|
|
🚨 Heads up:
|
Adds
GetUserAccessTokenandPythonUserAccessTokenRequestDtoto theIPythonJobApicontract, so a job can later ask the handler for a user access token, optionally with its own scopes. Nothing calls it yet. Server side: UiPath/hdens#8253.The method isn't abstract because the fakes in
tests/cli/test_job_api.pysubclassIPythonJobApi; the IPC proxy forwards any method on the class, so the body never runs.just lint,just formatandmypy src testspass. The package version still needs a bump from 2.14.25 before merge.🤖 Generated with Claude Code