Repository navigation
fix: recover locations from map home links - #217
Open
SamarthaB10 wants to merge 1 commit into
Open
SamarthaB10 wants to merge 1 commit into
SamarthaB10 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CourseBook can show a classroom while its link points to the main campus map. The parser skips the classroom in that case. Fixes #213.
Fix
When the link points to the main map, read building and room from matching location text. Leave the map link empty. Keep the existing handling for other links.
Verification
CSC,3.205, and an empty map link.go test ./parserandgo vet ./...passed.AI Disclosure
Samartha used Codex to understand the cause of hte parsing issue and then implement the fix