Repository navigation
Recognise pre-1.0 template About pages, and hide the upgrade offer once done - #64
Merged
Merged
Conversation
…ffering an upgrade once it is done
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped, the fixture hashes match, and no blocking issues remain.
No open issues 🎉
What changed in this PR
Extends template About-page recognition to pre-1.0 sites and removes the upgrade offer after completion.
Changes:
- Adds three historical About-page hashes and fixtures.
- Hides the newer-version subtitle when upgrading finishes.
- Adds regression tests for both behaviors.
| File | Description |
|---|---|
| tests/upgrade-sheet-flow-page.test.tsx | Tests subtitle removal after upgrade completion. |
| tests/fixtures/pages/telar-pre-1.0/NOTES.md | Documents historical fixture provenance. |
| tests/fixtures/pages/telar-pre-1.0/about-v0.9.1-beta.md | Adds the v0.9.1 template fixture. |
| tests/fixtures/pages/telar-pre-1.0/about-v0.9.0-beta.md | Adds the v0.9.0 template fixture. |
| tests/fixtures/pages/telar-pre-1.0/about-v0.6.0-beta.md | Adds the v0.6.0 template fixture. |
| tests/about-page-suggestion.test.ts | Tests recognition of historical About pages. |
| app/routes/_app.upgrade.tsx | Hides the subtitle in the completed stage. |
| app/lib/template-content.server.ts | Registers historical template-body hashes. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A site created before v1.0.0 that kept the template's About page now gets the Publish page's suggestion to make it its own, and imports no longer count that text as the author's. The Upgrade Telar page no longer says a newer version is available beside Upgrade complete. No D1 migrations, no new strings.