Skip to content

fix: make quick feedback draggable on desktop and mobile - #17

Merged
LIghtJUNction merged 1 commit into
mainfrom
fix/draggable-quick-feedback
Oct 22, 2026
Merged

LIghtJUNction merged 1 commit into
mainfrom
fix/draggable-quick-feedback

Conversation

@LIghtJUNction

Copy link
Copy Markdown
Contributor

移动端“快速反馈”会覆盖底部导航,固定位置也无法由用户调整。本次修改共享反馈组件,让用户把入口拖到合适的位置。

改动

  • 使用 Pointer Events 支持鼠标、触摸拖动,6px 阈值区分轻点与拖动,并处理指针取消/捕获丢失。
  • 按可视窗口限制位置,只保存相对坐标,刷新及窗口尺寸变化后保持入口可见;浏览器存储不可用时继续正常工作。
  • 手机工作区默认把入口放在底部导航上方,兼顾底部安全区。
  • 反馈面板跟随按钮,按上下可用空间展开并滚动,避免面板覆盖按钮;保留键盘打开、Escape 关闭和原有提交逻辑。

验证

  • JavaScript 模块语法检查通过。
  • node tests/feedback-ui.test.mjs:2/2 通过。
  • 本地 Chromium 实际交互:鼠标拖动、拖动不误弹、面板跟随/不重叠、刷新恢复位置、窗口缩放与边界限制、键盘操作、存储损坏/禁用回退通过。
  • 移动模拟:默认避开导航、触摸拖动、在已保存位置正常轻点打开通过。

验证限制:本地 CDP 连续“拖动→轻点”输入在原版组件和本次改动中均出现浏览器不生成 click 的情况,尚未确定模拟输入原因;未将这一连续手势标为验证通过,仍需手机实测。

Copilot AI balanced review requested due to automatic review settings October 22, 2026 06:31
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ⚠️ Failed 2026-10-22T06:31:26.363982Z
We couldn’t complete this review. Comment @codex security review to try again.
2f6b720 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

@LIghtJUNction
LIghtJUNction merged commit 81ebb94 into main Oct 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants