Repository navigation
fix(builder): give the Boat card its logo and a key link, open Settings as its popup, and drop the Engine card - #251
Merged
Merged
Conversation
… key to Settings The Where step's Boat card had no mark, unlike Settings. Without a key, the card now offers a button straight to Settings > Sandbox; other reasons Boat cannot run stay a plain line.
… only the Settings link live
…s key form, and say each Where error once
…oat card's descriptions, and name its link Add API Key
…s and Sandboxes switch
…er or Podman is under Hosts
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
🟡 PR judge · 8 of 8 yes · #251 ↔ #250
Acceptance criteria, 8 of 8 met
Checks the script runs itself, 4 of 4 pass
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #250
What
The Where step's Boat card gets Boat's mark (light or dark by theme) and loses its two description lines, which the Isolation line and Limits' concurrency already say. Without a Boat key, Sandboxes can now be chosen: the Boat card is greyed and its one live control, Add API Key, opens the Settings popup on Boat's key form. Every Settings link in the builder now opens the Settings popup (
window.nulliusOpenSettings, shared with the popup's own link handling) instead of leaving for the page, and closing the popup, however it was opened, reloads the builder from its draft on the same step. A Where problem is said once: the step no longer draws its own copy of "cannot run in a Boat VM", and a compile error can be markedshown(the missing Boat key, which the card already says) so the step's error line leaves it to Review. The machines sit 20px below the Hosts/Sandboxes switch. Settings → Sandbox drops its Engine card, its probe (sandbox.docker_state,_other) and #243's second-engine row with it: this machine's Docker or Podman is in the Hosts table.Touches
backend · routes · templates and static · docs and site
Before and after
Run builder, Where step, no Boat key:
Settings → Sandbox:
Verified
main.test_builder_where.py), a non-key Boat problem staying a plain line with Sandboxes disabled,shownset only when no key is saved (test_standard_boat.py), the Sandbox section without the Engine card and its route returning only Boat's state (test_settings_page.py).Risk
?run=or?saved=notice is not shown again.