Repository navigation
feat(builder): draw the Where step's machines and backends with sprite icons - #213
Merged
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #212
What
The Where step's tiles now show icons from the sprite in
base.html, not text glyphs. Four new symbols use the sprite's stroke style:i-machine: a screen on a stand, for This machine.i-network: one node linked to two, for each host.i-terminal: a window with a prompt, for Local processes.i-container: a ribbed shipping container, for Container.One
icon(name)helper incommand-builder.jswrites them.machineTileserves the standard and the Harbor Where steps, so both change. Boat keeps its logo. On the How it runs there row, the icons are 20 px, as that row's marks already were.Touches
templates and static (
base.html,builder/command-builder.js,builder/command-builder.css)Before and after
The Where step of a GSM8K standard recipe with three hosts. The host names are replaced with
host-1tohost-3in the shots.Verified
In a throwaway rootless
python:3.12container with Node.js and uv, on a copy of the branch:python3 app/tests/parallel.py: 2249 tests in 127 modules, OK.pip install -r app/requirements.txt, thenpython3 app/tests/parallel.py app/ui_tests: 638 tests in 53 modules, OK.Browser check, Chromium (Playwright 1.49.1): the shots above. No page JavaScript error.
Not checked: the Harbor recipe's Where step in a browser. It uses the same
machineTile.Risk
Low. Only the tiles' marks change. A revert brings the glyphs back.