Skip to content

fix(runs): read a null model name as none recorded - #211

Merged
harenome merged 1 commit into
ThinkFlowLab:mainfrom
harenome:fix/model-name-null
Nov 18, 2026
Merged

harenome merged 1 commit into
ThinkFlowLab:mainfrom
harenome:fix/model-name-null

Conversation

@harenome

Copy link
Copy Markdown
Collaborator

Closes #210

What

parse_job read agents[0].model_name with .get(key, ""). A present null passed through as None, and /runs failed with a 500 when it sorted the model names for its filter. The parser now reads a present null as "", the same as an absent key. The same change applies to reasoning_effort in the job config, in each agent of a multi-agent config and in a trial's config. There a null became the string "None". The importers and split_agents already read these fields with or "", so they do not change.

Touches

backend · routes (tests only)

  • app/nullius/runs/parse.py
  • app/tests/test_parse.py: a job with a null model name and null efforts parses to "".
  • app/ui_tests/test_controls_apart.py: /runs returns 200 with such a job beside a normal one, and no row shows None.

Verified

In a rootless Podman container (python:3.12, --init):

  • On main (be36d38), /runs over a job with model_name: null and a job with a model name returns 500 (TypeError: '<' not supported between instances of 'str' and 'NoneType'). On this branch it returns 200.
  • The backend suite, python3 app/tests/parallel.py: 2250 tests, OK.
  • The route suite, python3 app/tests/parallel.py app/ui_tests: 638 tests, OK.
  • With the parser of main, the two new tests fail: the route test with the TypeError, the parse test with (None, 'None', 'None') != ('', '', '').

Risk

Low. Only a present null reads differently. 0 and False are not valid values for these fields. No rendered class changes its fields. A revert undoes it.

A job config with agents[0].model_name: null left the job's model as
None, and the runs list's model filter sorted it beside strings: GET
/runs returned 500. A null reasoning_effort printed as "None" the same
way. Read a present null as the default, as an absent key already is.
@harenome
harenome merged commit 88557d3 into ThinkFlowLab:main Nov 18, 2026
2 checks passed
@harenome
harenome deleted the fix/model-name-null branch November 18, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runs: GET /runs returns 500 when a job config has a null model name

1 participant