Repository navigation
fix(runs): read a null model name as none recorded - #211
Merged
Merged
Conversation
A job config with agents[0].model_name: null left the job's model as None, and the runs list's model filter sorted it beside strings: GET /runs returned 500. A null reasoning_effort printed as "None" the same way. Read a present null as the default, as an absent key already is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #210
What
parse_jobreadagents[0].model_namewith.get(key, ""). A presentnullpassed through asNone, and/runsfailed with a 500 when it sorted the model names for its filter. The parser now reads a presentnullas"", the same as an absent key. The same change applies toreasoning_effortin the job config, in each agent of a multi-agent config and in a trial's config. There anullbecame the string"None". The importers andsplit_agentsalready read these fields withor "", so they do not change.Touches
backend · routes (tests only)
app/nullius/runs/parse.pyapp/tests/test_parse.py: a job with a null model name and null efforts parses to"".app/ui_tests/test_controls_apart.py:/runsreturns 200 with such a job beside a normal one, and no row showsNone.Verified
In a rootless Podman container (
python:3.12,--init):/runsover a job withmodel_name: nulland a job with a model name returns 500 (TypeError: '<' not supported between instances of 'str' and 'NoneType'). On this branch it returns 200.python3 app/tests/parallel.py: 2250 tests, OK.python3 app/tests/parallel.py app/ui_tests: 638 tests, OK.TypeError, the parse test with(None, 'None', 'None') != ('', '', '').Risk
Low. Only a present
nullreads differently.0andFalseare not valid values for these fields. No rendered class changes its fields. A revert undoes it.