Skip to content

feat(judge): put the judge's button under its badge, and say what its last call took - #197

Merged
aitianshi merged 9 commits into
mainfrom
feat/judge-call-summary
Nov 18, 2026
Merged

aitianshi merged 9 commits into
mainfrom
feat/judge-call-summary

Conversation

@aitianshi

@aitianshi aitianshi commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #195

What

On a trial's judge tabs the Judge button moves to the left, under the experimental badge. Once judged, a line beside it says what the judgement took: "Judged in 12.40s · jev-latest · 1.2k tokens · $0.0031", each part only when the record has it.

The client times its calls and keeps the seconds with the usage; a judgement of several calls adds them up. A judgement stored before this has no time and shows the rest.

Touches

  • backend: judge/client.py (the seconds in the usage, summed in merge)
  • templates and static: traces/_judgement.html, style.css
  • docs: settings/decision.md (the record's usage.seconds)
  • tests: test_judge.py, test_judge_openrouter.py, ui_tests/test_trial_head.py

Before and after

#196 and this branch on top of it, a trial with a stored judgement, dark, 1280 px.

Before After
Before: the button alone on the right After: the button under the badge, what the call took beside it

Verified

  • On refactor(judge): call the System One judgement Decision #196 (3483140): backend suite 2240 OK, route suite 563 OK.
  • A route test reads the line for a record with time, tokens and cost, and for an older one with neither time nor cost. It caught a crash on the older record, fixed before this was opened.
  • Not verified: a real judge call's time (no key used; the stored record is a seed).

Risk

Every page, message, document, setting and name says Decision: the
DECISION_PROVIDER, DECISION_PROTOCOL and DECISION_MODEL settings, the
decision lane, /settings/decision/models and docs/settings/decision.md.
Settings saved as SYSTEM_ONE_* are still read, and saving the new name
from the page takes the old line out of the file. Judgements stay in the
same folder. TypeSafe's protocol keeps its id and path, systemone.

Without a provider, the judge says it needs a model, not the TypeSafe
key: OpenRouter and OpenAI serve decision models too.
…e new one

The page showed DECISION_* unset and listed SYSTEM_ONE_* as unread while
the judge still used them. The file's old names are now read as the new
ones, so the page shows them set and the next save writes the new names.
The Judges section already says judge.
… last call took

On a trial's judge tabs the button sits on the left under the experimental badge. Once judged, a line beside it says how long the calls took, the model that answered, the tokens and the cost, each when the record has it. The client times its calls and keeps the seconds with the usage; a judgement of several calls adds them up.
@github-actions

This comment has been minimized.

@aitianshi
aitianshi changed the base branch from main to refactor/decision-judge November 18, 2026 00:11
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Base automatically changed from refactor/decision-judge to main November 18, 2026 00:16
@github-actions

Copy link
Copy Markdown

🟢 PR judge · 8 of 8 yes · #197 ↔ #195

Merge risk 🟠 SIGNIFICANT the judge's reading of the diff
Priority 🟠 HIGH the deepest path is app/nullius/judge/client.py
Question Verdict
Changes do what the issue asks · 4 of 4 criteria ✅ yes
Issue and pull request describe the same change ✅ yes
Description matches the diff, no more, no less ✅ yes
Diff stays in scope ✅ yes
Tests cover the change, or Verified says how ✅ yes
Docs follow the change ✅ yes
Risk named in the description ✅ yes
Before and after shown · 2 images · the diff touches what is visible ✅ yes
Acceptance criteria, 4 of 4 met
# Criterion Verdict
1 The Judge button sits on the left, under the experimental badge. ✅ met
2 Once judged, a line beside it says how long the calls took, the model, the tokens and the cost, each only when the reco… ✅ met
3 The client records each call's seconds with its usage; a judgement of several calls adds them up. ✅ met
4 A judgement stored before this, with no time, still shows. ✅ met
Checks the script runs itself, 4 of 4 pass
No machine attribution trailer in the commits or the description ✓
New code under app/, docs/, .github/ or .claude/ ✓
No Flask import under the backend package ✓
No key-shaped string in the diff ✓

@aitianshi
aitianshi merged commit 0d83e39 into main Nov 18, 2026
2 checks passed
@aitianshi
aitianshi deleted the feat/judge-call-summary branch November 18, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Judge tab: the button sits away from its badge, and a judgement does not say what its call took

1 participant