Repository navigation
feat(judge): put the judge's button under its badge, and say what its last call took - #197
Merged
Merged
Conversation
Every page, message, document, setting and name says Decision: the DECISION_PROVIDER, DECISION_PROTOCOL and DECISION_MODEL settings, the decision lane, /settings/decision/models and docs/settings/decision.md. Settings saved as SYSTEM_ONE_* are still read, and saving the new name from the page takes the old line out of the file. Judgements stay in the same folder. TypeSafe's protocol keeps its id and path, systemone. Without a provider, the judge says it needs a model, not the TypeSafe key: OpenRouter and OpenAI serve decision models too.
…e new one The page showed DECISION_* unset and listed SYSTEM_ONE_* as unread while the judge still used them. The file's old names are now read as the new ones, so the page shows them set and the next save writes the new names.
The Judges section already says judge.
… last call took On a trial's judge tabs the button sits on the left under the experimental badge. Once judged, a line beside it says how long the calls took, the model that answered, the tokens and the cost, each when the record has it. The client times its calls and keeps the seconds with the usage; a judgement of several calls adds them up.
This comment has been minimized.
This comment has been minimized.
…at/judge-call-summary # Conflicts: # app/templates/traces/_judgement.html
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🟢 PR judge · 8 of 8 yes · #197 ↔ #195
Acceptance criteria, 4 of 4 met
Checks the script runs itself, 4 of 4 pass
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #195
What
On a trial's judge tabs the Judge button moves to the left, under the experimental badge. Once judged, a line beside it says what the judgement took: "Judged in 12.40s · jev-latest · 1.2k tokens · $0.0031", each part only when the record has it.
The client times its calls and keeps the seconds with the usage; a judgement of several calls adds them up. A judgement stored before this has no time and shows the rest.
Touches
judge/client.py(the seconds in the usage, summed inmerge)traces/_judgement.html,style.csssettings/decision.md(the record'susage.seconds)test_judge.py,test_judge_openrouter.py,ui_tests/test_trial_head.pyBefore and after
#196 and this branch on top of it, a trial with a stored judgement, dark, 1280 px.
Verified
3483140): backend suite 2240 OK, route suite 563 OK.Risk
usage.seconds; older readers ignore it.main.