Repository navigation
fix(execution): preserve finished kit states in shared steps - #193
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
5 tasks
🟡 PR judge · 7 of 7 yes · #193 ↔ #192
Acceptance criteria, 5 of 5 met
Checks the script runs itself, 4 of 4 pass
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192
Depends on #188. Merge #188 first, then #193.
What
Conformance writes several kit jobs in one execution step. The shared running state and exit code made already completed kits remain running, then labelled all of them failed when a later kit failed. For standard jobs sharing a step, execution now reads a complete, error-free result as that job's own finish, with its own timestamp. This also works after restoring an execution from disk. The overall execution keeps its failure.
Incomplete, errored, unreadable or partially written results retain runner status. Harbor and single-job steps keep their existing exit semantics. Scores and execution commands are unchanged.
Touches
Backend (
execution) and backend and route regression tests.Before and after
Synthetic three-kit fixture, with two clean completions and one failing kit:
Before/after screenshots were captured and reviewed locally at 1280 and 390 pixels in light and dark themes. Image attachments are not uploaded to GitHub; this PR records the visible labels above.
Verified
test_execution_job_state,test_execution,test_execution_stop,test_execution_stop_restart.test_runs_by_launch,test_routes.job_stateimplementations. Both running and failed states checked at 1280 and 390 pixels, light and dark; no page JavaScript errors. At mobile width the existing layout hides the State column; the summary shows the corrected counts.git diff --checkpassed.Risk
The state reader now reads one small result file for a standard job sharing a step. A wrong completion decision could hide a failed process behind a finished job row. It requires a matching job ID, a finish timestamp, a positive planned count fully completed, and zero errored, cancelled, running or pending trials; otherwise it falls back to runner state. No record format or migration changes. Revert this commit to restore the previous display.