Skip to content

Read a meeting's state in the window's language (#3114) - #3267

Merged
Birfy merged 1 commit into
mainfrom
dev/3114-meeting-status-zh
Nov 20, 2026
Merged

Birfy merged 1 commit into
mainfrom
dev/3114-meeting-status-zh

Conversation

@Birfy

@Birfy Birfy commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Written-by: Dev
Fixes #3265
Part of #3114
Owner: Dev
Reviewer: Reviewer
Docs-not-needed: three dictionary keys and one t() in the Project board; no component structure changes.

What changed

Before: in a zh window the Project board's 「未决定」 record rows drew the host's meeting status id bare — open / deliberating / blocked. After: the same cell draws t(meeting.status), so a zh window reads 「待讨论 / 讨论中 / 待答复」, while an English window is byte for byte unchanged. The three ids become dictionary keys of their own beside running / stalled, the same shape this screen already uses for not-started / in-progress / done and ordinary / major / severe.

Two hand-written product files: the third argument of the one bt-project-status span (core/src/client/project-board.js:663, +1/−1) and three bare keys with a two-line comment (core/src/client/i18n.js, +5/−0). data-status (:656) and data-level (:642) stay the host ids — the new case asserts all four rows keep them. The question, the @speaker, the level badge and the blocking question are host data and untranslated. core/src/host/** is untouched: the host still owns the lifecycle and the read model still only emits those three pending statuses.

The case also carries an on-hold row the host never emits: a status the dictionary cannot name is drawn as it came, so the change is a lookup, never a guess or a mapping table.

Verification at the tip

Tip SHA: c7b0560acf7dbdf2a50cc37aee2bfc73f39a2c28 (tree d07e09c5bce30918436749340256d4655f00f185)

Ran at this tip:

$ cd core && TZ=UTC node --test test/project-board-view.test.js
# tests 39 / pass 39 / fail 0
$ cd core && TZ=UTC node --test test/i18n.test.js test/i18n-missing-entries.test.js test/i18n-template-draws.test.js test/i18n-plugins.test.js test/i18n-plugins-missing-zh.test.js
# tests 41 / pass 41 / fail 0
$ node -e "for (const f of ['i18n-plugins','i18n-template-draws','i18n-missing-entries','i18n-plugins-missing-zh']) console.log(f, require('./core/test/'+f+'.baseline.json').entries.length)"
i18n-plugins 12 / i18n-template-draws 9 / i18n-missing-entries 46 / i18n-plugins-missing-zh 2
$ node core/scripts/build-client.mjs --check            # rc 0
$ node scripts/ds-bot-patches.mjs canonical             # ok   patches/ds-bot/ is what generate writes (generate is a no-op)
$ node scripts/ds-bot-patches.mjs check                 # ok ds-bot/ pin; ok 10 patches apply cleanly; ok core/ equals ds-bot/ + patches/ds-bot/
$ node .github/scripts/changelog.mjs check              # 16 fragment(s) are well formed
$ git archive HEAD | tar -x -C <clean dir> && node .github/scripts/check-mojibake.mjs --check
mojibake: ok — 0 occurrences of U+FFFD in 1785 text file(s)
$ ARCH_DOCS_BASE=origin/main node core/scripts/check-arch-docs.mjs
arch-docs: OK (9 changed file(s))
$ git diff --shortstat origin/main...HEAD
9 files changed, 103 insertions(+), 6 deletions(-)

Red first — only the test added (file 39), implementation still at the merge base 641faf10:

  • cd core && TZ=UTC node --test test/project-board-view.test.js → # tests 39 / # pass 38 / # fail 1; case 39 stopped at 'open' !== '待讨论'. Clean main on the same file is 38/38/0.

At the tip: the same command → 39 / 39 / 0. The five i18n gates stay 41/41/0; the four baselines 12 / 9 / 46 / 2 are byte-identical (no --write was run, git diff --name-only origin/main...HEAD | grep -c baseline.json → 0). cd core && npm run build regenerated core/client.js; node scripts/ds-bot-patches.mjs generate twice (zero diff the second time); git status --porcelain empty; patches/ds-bot/topics.json untouched.

Risk gate on the nine changed paths, objects carrying patch (the shape the PR files API serves): T1 0 46 4 5 — hand-written 46 lines / 4 files, 5 generated paths. The two traps were confirmed on the same diff: 9 bare filename strings → T0 0 0 9 0, objects without patch → T3 4 46 4 5. Budget leaves 354 lines / 16 files. The forbidden surface regex hits 0 (core/src/host/, about.js, capability-settings.js, sidebar.js, topics.json, i18n-*.baseline.json), and the positive control on the same regex hits 3.

Not run (and why): the full TZ=UTC npm run verify. This box has only esbuild in the shared core/node_modules symlink (no @deepseek-ai/* harness packages, and the brief forbids npm ci), so the core suite cannot start here; CI at this tip carries the full suite. The affected test file, the five i18n gates, the bundle check and the patch checks were all run at this tip.

Checkpoint

{
  "pr": 3267,
  "claim": "Dev",
  "issue": 3265,
  "summary": "In a zh window the Project board's pending-meeting rows drew host ids open / deliberating / blocked; they now read 待讨论 / 讨论中 / 待答复. One drawn child now calls t(meeting.status), and three bare dictionary keys beside running / stalled name those ids. data-status, data-level and the host text stay host data; core/src/host/** is untouched and an unknown status (on-hold) is drawn as it came. One test (39th) covers both windows, the attribute and pass-through: red 39/38/1, fix 39/39/0. The bundle and the five generated patch artifacts were regenerated.",
  "files": [
    "changelog.d/3114-cut-35-meeting-status.fixed.md",
    "core/client.js",
    "core/src/client/i18n.js",
    "core/src/client/project-board.js",
    "core/test/project-board-view.test.js",
    "patches/ds-bot/0001-core-fixes.patch",
    "patches/ds-bot/0008-client-bundle.patch",
    "patches/ds-bot/files/src/client/project-board.js",
    "patches/ds-bot/files/test/project-board-view.test.js"
  ],
  "checks": {
    "ran": "project-board-view 39/38/1 then 39/39/0; five i18n gates 41/41/0; baselines 12/9/46/2; build + ds-bot-patches generate/canonical/check; build-client --check; changelog 16; mojibake 1785; arch-docs OK (9); risk gate T1 0 46 4 5",
    "result": "green",
    "at": "c7b0560acf7dbdf2a50cc37aee2bfc73f39a2c28"
  },
  "next": "none — ready for review"
}

Docs-not-needed: three dictionary keys and one t() in the Project board; no component structure changes.
@Birfy

Birfy commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

Written-by: Dev

实测(本机工作副本,tip c7b0560acf7dbdf2a50cc37aee2bfc73f39a2c28,基线 641faf101bcbebe5bbc946c95ef6b16b2f4e1f9b):

$ BASE=origin/main node <judge 片段,files 为带 patch 的对象>   # 9 条改动路径
T1 0 46 4 5
$ BASE=origin/main ...(files 换成 9 个文件名字符串)
T0 0 0 9 0
$ BASE=origin/main ...(对象不带 patch)
T3 4 46 4 5
$ git diff --numstat origin/main...HEAD | awk '$3 !~ /^(core\/client\.js|patches\/)/ {s+=$1+$2; f++} END {print s, f}'
46 4
$ node -e "for (const f of ['i18n-plugins','i18n-template-draws','i18n-missing-entries','i18n-plugins-missing-zh']) console.log(f, require('./core/test/'+f+'.baseline.json').entries.length)"
i18n-plugins 12
i18n-template-draws 9
i18n-missing-entries 46
i18n-plugins-missing-zh 2
$ git diff --name-only origin/main...HEAD | grep -c 'baseline.json'
0
  • 档位 T1 0 46 4 5(why.length 0、手写 46 行 / 4 文件 / 生成 5 路径);两个陷阱在同一份 diff 上复现:纯文件名字符串 T0 0 0 9 0(低一档),对象不带 patch T3 4 46 4 5(高两档)。
  • 四份基线 12 / 9 / 46 / 2 全部未动,本刀一条 --write 都没跑。
  • 红先 39 / 38 / 1('open' !== '待讨论')→ 绿 39 / 39 / 0;五道 i18n 门 41 / 41 / 0;changelog.mjs check 16 片段(main 15);归档树编码门 1785 text file(s) / 0 处 U+FFFD;arch-docs: OK (9 changed file(s))。
  • 没跑:整包 npm run verify(本机 core/node_modules 只共享 esbuild,没有 @deepseek-ai/*,且 brief 明确不跑 npm ci),详见 PR 正文。

停下等复核,不入队、不合。

@Birfy Birfy added the agent-pr Pull request opened by an agent label Nov 20, 2026
@Birfy Birfy self-assigned this Nov 20, 2026
@Birfy Birfy added agent-pr Pull request opened by an agent and removed agent-pr Pull request opened by an agent labels Nov 20, 2026
@Birfy

Birfy commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

Enqueue evidence — #3267 (Cut 35, T1)

Read 2026-11-20T12:31Z–12:34Z UTC through GET /repos/ThinkFlowLab/FlyBot/pulls/3267, /commits/{sha}/check-runs, /graphql (PR + mergeQueue(branch:"main")), and the .github/scripts/risk-gate.mjs --pr 3267 client, on a tarball of the tip and of main.

Tip c7b0560acf7dbdf2a50cc37aee2bfc73f39a2c28 (tree d07e09c5bce30918436749340256d4655f00f185), base main 641faf101bcbebe5bbc946c95ef6b16b2f4e1f9b. Re-read at enqueue time; the tip did not move.

Seven spot checks (measured here, not copied from the body)

  1. 9 files, +103/−6 — core/src/client/project-board.js +1/−1; core/src/client/i18n.js +5/−0; core/test/project-board-view.test.js +38/−0; changelog.d/3114-cut-35-meeting-status.fixed.md +1/−0; core/client.js +6/−1; patches/ds-bot/0001-core-fixes.patch +6/−1; patches/ds-bot/0008-client-bundle.patch +7/−2; patches/ds-bot/files/src/client/project-board.js +1/−1; patches/ds-bot/files/test/project-board-view.test.js +38/−0. No patches/ds-bot/files/src/client/i18n.js (absent at base and at the tip).
  2. Dictionary adds only: removed lines in core/src/client/i18n.js → 0; ^ (open|deliberating|blocked): ' → 3 (lines 1618–1620), byte for byte 待讨论 / 讨论中 / 待答复.
  3. The draw point is the only change: bt-project-status' }, meeting.status → 0; 'data-status': meeting.status → 1 (the attribute keeps the host id).
  4. on-hold pass-through: the new case carries an on-hold row (:1085) and asserts it is drawn as it came (:1100) and that data-status reads ['open','deliberating','blocked','on-hold'] (:1102).
  5. Baselines untouched: changed *baseline.json → 0; entries 12 / 9 / 46 / 2.
  6. Forbidden surface 0: core/src/host/, patches/ds-bot/topics.json, about.js, capability-settings.js, sidebar.js, *baseline.json — no changed path matches; the same paths are unchanged at :661 (meeting.advance.reason still host data, no t() added around it). Positive control on the same scan: 4 changed paths matching project-board.
  7. Generated artifacts self-consistent: node core/scripts/build-client.mjs --check rc 0; node scripts/ds-bot-patches.mjs canonical → ok patches/ds-bot/ is what generate writes (generate is a no-op); check → ok 10 patches apply cleanly in order + ok core/ equals ds-bot/ + patches/ds-bot/ (the pin line is skipped on this box: the tarball tree is not a git checkout, so there is no tree hash to compare); the tree carries no file outside the nine.

Red first → green (run twice here)

  • Red, implementation at the base 641faf10 with only the new test kept: cd core && TZ=UTC node --test test/project-board-view.test.js → 39 / 38 / 1, not ok 39, 'open' !== '待讨论'.
  • Green, tip tree: same command → 39 / 39 / 0.
  • Five i18n gates at the tip → 41 / 41 / 0.

Tier (computed here, not copied)

node .github/scripts/risk-gate.mjs --pr 3267 --repo ThinkFlowLab/FlyBot → risk-tier: T1; size line 46 changed lines in 4 files; 5 generated file(s) not counted — i.e. T1 0 46 4 5. T1 merges through the queue on green CI, no PASS needed.

CI and gate state at the tip

24 check-runs, all terminal: 18 success, 4 cancelled (one duplicate suite each of judge and agent-audience, not the diff), 2 skipped (live · real model, window check), 0 failure; tests-ok, merge-gate, policy-sign, enqueue-guard all success. mergeable: MERGEABLE, mergeStateStatus: CLEAN, not draft, base main, label agent-pr, no hold. Merge queue on main empty at read time.

@Birfy
Birfy added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 4031b9e Nov 20, 2026
20 of 24 checks passed
@Birfy
Birfy deleted the dev/3114-meeting-status-zh branch November 20, 2026 12:34
@github-actions github-actions Bot removed the agent-pr Pull request opened by an agent label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

项目看板:未决定会议的 open / deliberating / blocked 按窗口语言显示(Cut 35)

1 participant