Repository navigation
Read the capability refusals that carry a name in the window's language (#3114) - #3262
Merged
Merged
Conversation
…ge (#3114) Docs-not-needed: three HOST_ERRORS patterns and their tests; no component or host change.
Collaborator
Author
Enqueue evidence — tip
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Fixes #3261
Part of #3114
Owner: Dev
Reviewer: Reviewer
Docs-not-needed: three HOST_ERRORS patterns and their tests; no component or host change.
What changed
Before: in a zh window the Capabilities page drew three host refusals that carry a name in English — the pack whose child capability is gone, the capability that is no longer there (Delete and the Bot capability switch are the same sentence), and the unapproved stdio MCP. After: those three read Chinese, with the name copied straight through from the host message. An English window is unchanged: the English sentences were not edited, no static key was added, and neither
capability-settings.js/settings.js/api.js/channel.jsnorcore/src/host/**was touched.Three whole-sentence patterns appended to
HOST_ERRORS($1is the name, not{name}):^Packs can include only saved MCP servers and skills\. (.+) is not one\.$→能力包里只能放已保存的 MCP 服务和技能;$1 不是其中之一。^No capability named (.+)\.$→找不到叫 $1 的能力。^No unapproved stdio MCP named (.+)\.$→找不到叫 $1 的待批准 stdio MCP 服务。stdiostays as the host wrote it: it names the transport the Allow button is about.Unknown capability operationand the Bot tool'schangeAttachmentsentence are deliberately left English (no caller reacheshostTextfor either).Verification at the tip
Tip SHA:
60fb6bd3032fe53bca56a73f868ec234a1a64f18(tree0b4d1c58df067c0843afa0d9c3b7761578c854b8)Ran:
core/src/client/i18n.jsback at the merge base:(cd core && TZ=UTC node --test test/i18n.test.js test/settings-error-placement.test.js)→# tests 11 / # pass 8 / # fail 3, failing4 / 10 / 11; case 10's actual value was the EnglishPacks can include only saved MCP servers and skills. web-search is not one.; per file5 / 4 / 1and6 / 4 / 2.(cd core && TZ=UTC node --test test/i18n.test.js test/settings-error-placement.test.js)→# tests 11 / # pass 11 / # fail 0;test/i18n.test.js5 / 5 / 0;test/settings-error-placement.test.js6 / 6 / 0.test/i18n.test.js test/i18n-missing-entries.test.js test/i18n-template-draws.test.js test/i18n-plugins.test.js test/i18n-plugins-missing-zh.test.js) →41 / 41 / 0(clean main 39); the three baselines12 / 9 / 46ok.node core/scripts/build-client.mjs --check→ rc 0;git diff --exit-code -- core/client.jsrc 0.node scripts/ds-bot-patches.mjs canonical→ok patches/ds-bot/ is what generate writes (generate is a no-op);check→ threeoklines (ds-bot pin, 10 patches apply in order, core equals ds-bot + patches);git status --porcelainempty.node .github/scripts/changelog.mjs check→ 14 well-formed fragments;node .github/scripts/check-mojibake.mjs --check→ rc 0 (0 U+FFFD in 1783 text files);ARCH_DOCS_BASE=origin/main node core/scripts/check-arch-docs.mjs→arch-docs: OK (8 changed file(s)).T1 0 79 4 4; hand-written+79/−0across 4 files, generated 4 paths+97/−5,patches/ds-bot/topics.jsonuntouched.Not run: the full
TZ=UTC npm run verify. This box has onlyesbuildin the sharedcore/node_modulessymlink and no harness packages (@deepseek-ai/*resolves to an empty/tmp/dvinst), andnpm ciwould delete that symlink itself, so the core suite cannot start. What was run instead, beyond the gates above:node --test ".github/scripts/*.test.mjs" "policy/*.test.mjs"→# tests 714 / pass 712 / fail 0(2 skipped). CI at this tip carries the full suite.Checkpoint
{ "pr": 3262, "claim": "Dev", "issue": 3261, "summary": "In a zh window the Capabilities page's three named host refusals now read Chinese with the name copied through untouched: the pack whose child capability is gone, No capability named (Delete and the Bot capability switch), and No unapproved stdio MCP named. Three whole-sentence HOST_ERRORS patterns and four tests; no component, host or English sentence changed. The generated client bundle and the three patch mirrors were regenerated, not hand-edited.", "files": [ "core/src/client/i18n.js", "core/test/i18n.test.js", "core/test/settings-error-placement.test.js", "changelog.d/3114-capability-refusals-zh.fixed.md" ], "checks": { "ran": "two-file red-first 11/8/3 then 11/11/0 + five i18n gates 41/41/0 + build-client --check + ds-bot-patches check/canonical + changelog + mojibake + arch-docs + risk gate", "result": "green", "at": "60fb6bd3032fe53bca56a73f868ec234a1a64f18" }, "next": "none — ready for review" }