Skip to content

Read the capability refusals that carry a name in the window's language (#3114) - #3262

Merged
Birfy merged 1 commit into
mainfrom
dev/3114-capability-refusals-zh
Nov 20, 2026
Merged

Birfy merged 1 commit into
mainfrom
dev/3114-capability-refusals-zh

Conversation

@Birfy

@Birfy Birfy commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Written-by: Dev
Fixes #3261
Part of #3114
Owner: Dev
Reviewer: Reviewer
Docs-not-needed: three HOST_ERRORS patterns and their tests; no component or host change.

What changed

Before: in a zh window the Capabilities page drew three host refusals that carry a name in English — the pack whose child capability is gone, the capability that is no longer there (Delete and the Bot capability switch are the same sentence), and the unapproved stdio MCP. After: those three read Chinese, with the name copied straight through from the host message. An English window is unchanged: the English sentences were not edited, no static key was added, and neither capability-settings.js / settings.js / api.js / channel.js nor core/src/host/** was touched.

Three whole-sentence patterns appended to HOST_ERRORS ($1 is the name, not {name}):

  • ^Packs can include only saved MCP servers and skills\. (.+) is not one\.$ → 能力包里只能放已保存的 MCP 服务和技能;$1 不是其中之一。
  • ^No capability named (.+)\.$ → 找不到叫 $1 的能力。
  • ^No unapproved stdio MCP named (.+)\.$ → 找不到叫 $1 的待批准 stdio MCP 服务。

stdio stays as the host wrote it: it names the transport the Allow button is about. Unknown capability operation and the Bot tool's changeAttachment sentence are deliberately left English (no caller reaches hostText for either).

Verification at the tip

Tip SHA: 60fb6bd3032fe53bca56a73f868ec234a1a64f18 (tree 0b4d1c58df067c0843afa0d9c3b7761578c854b8)

Ran:

  • red first, only the two tests in place and core/src/client/i18n.js back at the merge base: (cd core && TZ=UTC node --test test/i18n.test.js test/settings-error-placement.test.js) → # tests 11 / # pass 8 / # fail 3, failing 4 / 10 / 11; case 10's actual value was the English Packs can include only saved MCP servers and skills. web-search is not one.; per file 5 / 4 / 1 and 6 / 4 / 2.
  • at the tip: (cd core && TZ=UTC node --test test/i18n.test.js test/settings-error-placement.test.js) → # tests 11 / # pass 11 / # fail 0; test/i18n.test.js 5 / 5 / 0; test/settings-error-placement.test.js 6 / 6 / 0.
  • at the tip, the five i18n gates (test/i18n.test.js test/i18n-missing-entries.test.js test/i18n-template-draws.test.js test/i18n-plugins.test.js test/i18n-plugins-missing-zh.test.js) → 41 / 41 / 0 (clean main 39); the three baselines 12 / 9 / 46 ok.
  • node core/scripts/build-client.mjs --check → rc 0; git diff --exit-code -- core/client.js rc 0.
  • node scripts/ds-bot-patches.mjs canonical → ok patches/ds-bot/ is what generate writes (generate is a no-op); check → three ok lines (ds-bot pin, 10 patches apply in order, core equals ds-bot + patches); git status --porcelain empty.
  • node .github/scripts/changelog.mjs check → 14 well-formed fragments; node .github/scripts/check-mojibake.mjs --check → rc 0 (0 U+FFFD in 1783 text files); ARCH_DOCS_BASE=origin/main node core/scripts/check-arch-docs.mjs → arch-docs: OK (8 changed file(s)).
  • the risk gate on the eight changed paths prints T1 0 79 4 4; hand-written +79/−0 across 4 files, generated 4 paths +97/−5, patches/ds-bot/topics.json untouched.

Not run: the full TZ=UTC npm run verify. This box has only esbuild in the shared core/node_modules symlink and no harness packages (@deepseek-ai/* resolves to an empty /tmp/dvinst), and npm ci would delete that symlink itself, so the core suite cannot start. What was run instead, beyond the gates above: node --test ".github/scripts/*.test.mjs" "policy/*.test.mjs" → # tests 714 / pass 712 / fail 0 (2 skipped). CI at this tip carries the full suite.

Checkpoint

{
  "pr": 3262,
  "claim": "Dev",
  "issue": 3261,
  "summary": "In a zh window the Capabilities page's three named host refusals now read Chinese with the name copied through untouched: the pack whose child capability is gone, No capability named (Delete and the Bot capability switch), and No unapproved stdio MCP named. Three whole-sentence HOST_ERRORS patterns and four tests; no component, host or English sentence changed. The generated client bundle and the three patch mirrors were regenerated, not hand-edited.",
  "files": [
    "core/src/client/i18n.js",
    "core/test/i18n.test.js",
    "core/test/settings-error-placement.test.js",
    "changelog.d/3114-capability-refusals-zh.fixed.md"
  ],
  "checks": { "ran": "two-file red-first 11/8/3 then 11/11/0 + five i18n gates 41/41/0 + build-client --check + ds-bot-patches check/canonical + changelog + mojibake + arch-docs + risk gate", "result": "green", "at": "60fb6bd3032fe53bca56a73f868ec234a1a64f18" },
  "next": "none — ready for review"
}

…ge (#3114)

Docs-not-needed: three HOST_ERRORS patterns and their tests; no component or host change.
@Birfy Birfy added the agent-pr Pull request opened by an agent label Nov 20, 2026
@Birfy Birfy self-assigned this Nov 20, 2026
@Birfy
Birfy added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 422a672 Nov 20, 2026
19 of 20 checks passed
@Birfy
Birfy deleted the dev/3114-capability-refusals-zh branch November 20, 2026 10:03
@github-actions github-actions Bot removed the agent-pr Pull request opened by an agent label Nov 20, 2026
@Birfy

Birfy commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

Enqueue evidence — tip 60fb6bd3

Written-by: enqueue
Read at 2026-11-20T10:07Z (UTC). Sources: REST /pulls/3262, /pulls/3262/files, /commits/60fb6bd3/check-runs, /commits/422a672c/check-runs, GraphQL mergeQueueEntry; local tip tree compared against the PR blob shas.

Four checks

  1. Tier T1, not T2/T3 — inline createGate on the 8 PR files: risk-tier: T1, judge T1, 79L/4F, 4 generated. T1 route, no PASS required.
  2. Tip checks — 20 runs, all terminal: 18 success, 2 skipped (live · real model, window check), 0 failure / 0 cancelled. tests-ok, merge-gate, enqueue-guard, policy-sign, judge all success.
  3. PR state — open, not draft, base main @ dd7599d3, mergeable clean, no hold label, labels agent-pr, body Fixes #3261 / Part of #3114.
  4. Checkpoint — block 1073 chars (≤1500): pr=3262, claim=Dev, issue=3261, summary 454 (≤600), files 4/4 all in this diff (i18n.js, i18n.test.js, settings-error-placement.test.js, changelog), checks green @ tip, next 23.

Content spot-checks on the tip tree (all 8 blobs match the PR file shas)

  • Three regexes sit between Composio answered and the closing ] of HOST_ERRORS, verbatim: Packs can include only saved MCP servers and skills\. (.+) is not one\., No capability named (.+)\., No unapproved stdio MCP named (.+)\.; i18n.js diff is +7/−0 (3 patterns + 4 comment lines).
  • $1 count: main 37 → tip 40; 0 new HOST_ZH hits in added lines; Unknown capability operation 0.
  • English untouched: 0 - lines in the i18n.js diff; Packs can include only saved MCP servers and skills appears once.

Red first → green (same command: cd core && TZ=UTC node --test test/i18n.test.js test/settings-error-placement.test.js)

  • base tree (main dd7599d3 i18n.js): 11 tests / 8 pass / 3 fail — failures 4, 10, 11.
  • tip tree: 11 tests / 11 pass / 0 fail.

Queue → merge

  • Enqueued at 60fb6bd3032fe53bca56a73f868ec234a1a64f18; entry MQE_lQDOVIxL0c8AAAABQoY8Z84ABOPczgQrs3o QUEUED pos 1 → AWAITING_CHECKS → merged.
  • merge_group 422a672c6e: Test success, Merge gate success, Enqueue guard success.
  • Merge commit 422a672c6e277ae741f08744f63e3073f7da9657 (squash, parent dd7599d3); main new head is the same sha, push CI 21/21 completed success incl. tests-ok.

Closeout — #3261 is closed/completed (10:03:33Z); #3114 remains open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

设置 › 能力页的带名拒绝句按窗口语言显示(Cut 33)

1 participant