Repository navigation
Conversation
…kFlowLab#3095) `.github/agent/` holds the data the gates read: risk tiers, who may record a PASS and the writers roster, who keeps an issue agent-ready, and the ruleset `gate-ruleset --check` compares against. Two of those files say "Editing this file is itself T3", which locks nothing: the tier picks which gate judges a change, never whether a person has to sign it. `risk-tier.yml` is the same shape one level down — report-only, out of `tests-ok`'s needs, and the source of the `risk-tier: …` line a review quotes. `gateFiles` now names the directory and that workflow, so rule data added later is covered by construction. The ThinkFlowLab#2303 test learns the one stated exception: a workflow can need a signature without being a merge gate. Tests cover the four roster/rule files, the typo guard on the directory entry, the `judge()` counterexample both ways, and the negative controls.
|
@Birfy — one review request on this tip: What it changes: adds Two checks are red by design here: Written-by: FlyBot Lead |
|
Written-by: FlyBot Lead Signature request at this tip, quoted in full because a later push voids it: A gate file changed, so Please reply once with both things in that one comment:
This tip has not been measured locally (it is the newest of the gate pull requests); what it carries is green CI apart from |
|
Verdict: PASS at 290a16a Ran at this tip: 第一条在 codeload 拉下来的 tip tarball 上跑(未手改任何文件);第二条是红先:只把 范围:base 数据面: 红先:换回 base blob 后,4 条新 环境:2 条 skip 是 tip 上的 check-runs: 入队侧已知阻塞(照实带回,不重试、不改正文凑签名、不动队列):这个 head 是 gate file 改动,四查②要求 元数据:按 AGENTS.md, |
Fixes #3095
Written-by: FlyBot Dev-1
Owner: Dev-1
Reviewer: Reviewer
Tier: T2 (risk-gate over
policy/**, which no rule names; both T2 and T3 need a PASS at the tip)Claim-Id: cc02a85fb29b407693d723d7dcb3ea5f
Base: faf7792
What changed
policy-signansweredok: true — no gate file changedfor all four files in.github/agent/and for.github/workflows/risk-tier.yml. A pull request could move the reviewer roster, the maintainers list the controller trusts, the risk tiers, the rulesetgate-ruleset --checkcompares against, or the workflow that writes therisk-tier: …line a review quotes, with no signature from anyone. Two of those files even carried the sentence "Editing this file is itself T3", which locks nothing: the tier decides which gate judges a change, never whether a person has to sign it.gateFilesnow names the directory.github/agent/— rule data added later is covered by construction rather than by remembering another line — and the tier runner.github/workflows/risk-tier.yml. A change to either is refused until the body carriesPolicy-sign: <comment id>naming a comment by someone other than the author that names the tip. No workflow content changed and the four rule JSONs are untouched.The #2303 test called any workflow in
gateFilesthat the manifest does not markgate: truea stale entry, which would flag the report-only tier runner. It now carries the one stated exception and pins the manifest row, so a manifest that stops calling the runner report-only has to move the entry in the same change.Red first
With the two source entries absent and the tests added,
node --test policy/gates.test.mjs:# tests 7 / # pass 4 / # fail 3gateFiles(['.github/agent/controller.json']),…/merge-gate-ruleset.json,…/review-policy.json,…/risk-rules.jsonall returned[]— refusal: "the rules that decide what counts as ready, as a PASS and as T3 need a person's signature; add.github/agent/togateFilesin policy/gates.json"gateFiles(['.github/workflows/risk-tier.yml'])returned[]judge()answeredok: truefor a body that movesreview-policy.json'sreviewersand carries noPolicy-sign:line —true !== falseWith the two entries in
policy/gates.json:# tests 7 / # pass 7 / # fail 0, run twice.Verification at the tip
Tip SHA:
290a16ab6e0f44e70f722319d3093e859d20fdb3(pushed head, built from tree664e9c27a25e5db3647d78de2093ee017ddb0b7c= the local verified commit4f3ea1353552c1acae4a4780cdd51433bbab05a2), on basefaf779297abb6a7122182db6d034e392d9653ee2(the pushed head is built from this tree by the push path; every reading below ran on this tree).Ran:
node --test policy/gates.test.mjs→ 7/7, twiceTZ=UTC npm run verify→ exit 0: core 3376/3376/0, plane 25/25/0, social 758/758/0, tree 152/152/0, timeline 172/172/0, workflow 538/538/0, project 151/151/0,.github/scripts690/690/0,policy7/7/0, interop 37/37/0, live-e2e 34/34/0npm run lintinside that run → oxlint91 warnings and 0 errors;arch-docs: OK (2 changed file(s)); plugin lints 40/9/2/16 warnings, 0 errorsnode core/scripts/build-client.mjs --check→ 0node scripts/ds-bot-patches.mjs check→ 0, three lines:ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00, v0.1.5),10 patches apply cleanly in order,core/ equals ds-bot/ + patches/ds-bot/node scripts/ds-bot-patches.mjs canonical→ 0,ok patches/ds-bot/ is what generate writes (generate is a no-op); then a realgenerate→ 0 andgit status --porcelain0 linesnode .github/scripts/changelog.mjs check→ 0,10 fragment(s) in changelog.d/ are well formed(no fragment added: no user-visible behavior changes, and this issue scopes the diff to the twopolicy/files)Not run (and why): the smoke bench — nothing under
core/index.jsorcore/src/host/changed; this diff ispolicy/only.policy-signon this pull request is expected to stay red: the change editspolicy/gates.jsonitself, and only a person writes thePolicy-sign:line naming a comment that names the tip. No Bot on the team writes that line.Checkpoint
{ "pr": 3247, "claim": "Dev-1", "issue": 3095, "summary": "policy-sign ignored the rule data the gates read: the four .github/agent/*.json files and the report-only workflow that writes the risk-tier line were not gate files, so a pull request could move the reviewer roster, the maintainers list, the risk tiers or the ruleset with no signature. gateFiles now names the .github/agent/ directory and .github/workflows/risk-tier.yml. Tests cover the directory by its real files, the judge() counterexample both ways, and the negative controls; the #2303 test carries the one stated signature-only workflow exception. No rule JSON or workflow content changed.", "files": ["policy/gates.json", "policy/gates.test.mjs"], "checks": { "ran": "TZ=UTC npm run verify; node --test policy/gates.test.mjs; node scripts/ds-bot-patches.mjs check, canonical, generate; node core/scripts/build-client.mjs --check", "result": "green", "at": "4f3ea1353552c1acae4a4780cdd51433bbab05a2" }, "next": "none — ready for review; a human `Policy-sign:` line naming a comment at the pushed tip is still required before the queue" }