Skip to content

The T1 queue trigger decides alone: gate its own script and workflow #3251

Open

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 63bbfdec398e40b0b5427c5b0c66d08e
Branch: dev/5-cover-auto-queue
Base: faf7792
At: 2026-11-20T05:36:18Z

Implementation: FlyBot (ours) — PR follows later; this one waits on the signature path. Do not pick up without a pickup-ok comment.
Written-by: FlyBot Lead
Bot: FlyBot Dev-5

#3248 adds .github/scripts/auto-queue-t1.mjs and .github/workflows/auto-queue-t1.yml: a workflow that decides, on its own, which T0/T1 pull requests go into the merge queue. Neither path is in policy/gates.json gateFiles, so a change to that decision logic or to that workflow needs no Policy-sign: line at all. A thing that can press the queue and merge without a person is exactly what the signature gate exists to catch, and today it would sit outside it.

This was known when the design was accepted ("a workflow that can queue itself and is not covered by the gate is itself a hole"); this issue is the record, so it does not stay a verbal one.

What to change

  • policy/gates.json: add .github/scripts/auto-queue-t1.mjs and .github/workflows/auto-queue-t1.yml to gateFiles (both exact paths — the existing list is exact paths, not directory prefixes).
  • policy/gates.test.mjs: pin it — gateFiles([...those two paths...]) must return them, and judge() must refuse a body that edits either one with no Policy-sign: line, and accept it with a signed comment that names the tip.

Dedupe (checked before opening)

  • live main grep: neither path exists in policy/gates.json yet; they only appear once #3248 merges.
  • closed issues: #2093 / its fix #2095 covered the queue gates that already existed (enqueue-guard.mjs and friends); #2731 covers test.yml vs its composite action. None of them covers these two new paths.
  • open: #3248 is the PR that introduces the files; #3247 / #3095 extend gateFiles to .github/agent/ and risk-tier.yml and do not name either new path.

Constraint

Its own PR edits policy/gates.json, so policy-sign will be red by design and only a non-author human Policy-sign: line naming the tip can clear it — the same wall as the frozen #3247, #2547, #2875, #3067, #3088, #3092. Do not pick this up until the Lead posts a pickup-ok comment saying the signature path exists; until then it is a record, not a work item.

Acceptance

  • gateFiles returns both new paths; a body that edits either one without a signature is refused by judge() with the signature reason, and accepted when a comment naming the tip signs it.
  • Red-first: the new assertions fail on the base, pass after the two entries are added.
  • npm run verify exit 0, arch-docs clean, no other policy/gates.json entry touched.

Activity

  1. Birfy commented on Nov 20, 2026

    @Birfy
    Collaborator

    Written-by: Triage

    在飞:已认领 Claim-Id 63bbfdec398e40b0b5427c5b0c66d08e(FlyBot Lead,2026-11-20T05:36Z,分支 dev/5-cover-auto-queue,PR 未开)。标 agent-working 只为不重复认领,不构成接手许可:正文写明要等 pickup-ok,且 policy/gates.json 自身是 gate file,签名线出现前不动。

  2. added
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Nov 20, 2026
  3. Birfy commented on Nov 20, 2026

    @Birfy
    Collaborator

    Written-by: Chief(2026-11-20T20:02Z 读盘)

    把这条的状态说清楚,免得有人以为它在推进:

    • 那条 claim 63bbfdec398e40b0b5427c5b0c66d08e(FlyBot Lead,05:36Z,分支 dev/5-cover-auto-queue)已经没有持有者。常驻 Bot 团队在 10-27 就被清空,活改由 workflow 的临时节点跑,所以 14 小时没开 PR 不是慢,是没人接。
    • 它本身也不是"等 CI/等 review":改动面含 policy/gates.json,属 gate file,签名线没解之前动不了;正文要求的 pickup-ok 也没出现。
    • 处置:保持 open、保持 agent-working(只为防重复认领),不派实现线。等 owner 把签名口径定下来,再由 workflow 重新 claim、按红先的开法做。

    一句话:这条卡的是签名许可,不是工时。

  4. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Nov 20, 2026
  5. Birfy commented on Nov 20, 2026

    @Birfy
    Collaborator

    Written-by: Chief(2026-11-20T23:30Z 读盘)

    23:18:48Z 的 Controller (labels only) 运行(run 44835780062)把这条的 agent-working 摘掉了,事件里记的是 unlabeled by github-actions[bot]。原因不是有人接手,是 .github/scripts/controller.mjs 的 claim-expired 规则命中:claim 超过 claimTtlHours=6、且没有 Fixes #N 的开放 PR 在该窗口内有提交或新开。05:36Z 那条 claim 63bbfdec398e40b0b5427c5b0c66d08e 早已无持有者,所以这是预期内的自动化清理,不是缺陷。

    需要更正我 20:02Z 那条的口径:当时写的「保持 agent-working 防重复认领」现在已经不成立——标签被自动摘掉后,这条单目前没有任何状态标签,理论上可以被重新认领。

    结论不变:改动面含 policy/gates.json(gate file),签名线没解之前动不了;请勿重新认领,认领了也过不了 policy-sign,只会白烧一轮。等 owner 把签名口径定下来,再按正文 TODO 重新开。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions