Skip to content

⌘K palette drops a real hit: the dedupe key is chat:turn, so an older part's row vanishes #3235

Closed

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: ffea36b1f2f749fb8a20473c48dc1efa
Branch: dev/1-palette-part-dedupe
Base: ffe6f3d
At: 2026-11-20T00:13:29Z

Tier: T1 — core/src/client/palette.js plus its test; it is the client-bundle lane (core/client.js + patches/ds-bot/0008), so the PR waits behind #3112 and behind our four in-flight T2 pull requests.

What a user sees

In the ⌘K palette, a hit from an older part of the same chat silently disappears when the current part's outline has a row with the same turn number. With one older-part hit at turn 1 and a current-part outline hit at turn 1, the whole Messages (full text) section vanishes — no row, no Earlier part badge. When the older part's turn is 2, both sections appear and the badge shows. Because turn numbers are per part, two different messages collide.

Where

  • core/src/client/palette.js:124 — !outlined.has(${row.chat}:${row.turn}) (dedupe key built from chat + turn only).
  • :107 — the messages key is chatOf(id):turn; :116 builds outlined; :129 is the first place row.part is used; :130–134 build the full-text row key at = chat:turn with keyCounts; :158–166 activate through rows[active] / row.run().

Reproduction (read-only, base c0061ba0)

Two independent probes agree on two bases (5f6c8321, c0061ba0); the second rebuilt core/src/client/palette.js from real source with esbuild plus a fake React:

  • A: older-part row {chat:'s1', turn:1, part:'s1-old'} vs a current-part outline hit on turn 1 → sections: ["Messages"], rows: ["Messages -> s1:1"]; the full-text section is gone.
  • B: the same with turn 2 → both sections plus [Earlier part].
  • C: same part, same turn → deduped correctly, so the chat:turn dedupe is right in principle and only too coarse across parts.

Expected

  • The dedupe key and the full-text row key both carry the part: chat:(part ?? chat):turn (room rows fall back to chat; keeps #3114's "part id ≠ Bot id").
  • keyCounts counts on the same triple, so keys do not collide.
  • Acceptance asserts sections() and badge text by section/position, never through choose(key); add "same chat + turn, different part → keys do not collide" as its own case.
  • A naive fix that adds the part to outlined only is not acceptable: both sections then render but s1:1 appears twice and choose('s1:1') returns the outline row while clicking the full-text row opens {part:'s1-old', turn:1}.

Boundaries

  • Files: core/src/client/palette.js, its test, core/client.js + patches/ds-bot/0008 (regenerated, never hand-edited), changelog.d/<issue>-palette-part-dedupe.fixed.md.
  • No core/src/host/**, no gate files, no .github/**, no plugins/**.
  • Red first on a clean base; the PR must state the bundle regeneration and the ds-bot-patches check/canonical result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions