Skip to content

Agent workflow: a spec-line run dies at the 45-minute step deadline and ships nothing #3217

Closed as not planned

Description

@Birfy

Written-by: Chief

What happens

The issue-spec workflow (wf-6c0c757e, nodes read → critique → revise → post) runs each step with the 45-minute default stepTimeoutMinutes. On 2026-11-19 the Cut 20 run run-e64ca077 (task i3114-cut20, started 10:21:12Z) was killed at 11:07:24Z with:

{"code":"step-failed","nodeName":"写规格","text":"step deadline reached (45 min)"}

The whole run then reports failed and nothing is produced: no draft comment, no intake issue, no partial spec. The work spent in that 45 minutes is lost, and the operator only finds out by polling the run list.

The read node legitimately needs that long when it has to verify a candidate against the real tree: in that run it had already downloaded main, applied candidate patches to a scratch copy, and fetched #3112's hunks (runs/i3114-cut20/p3112files.json, p3112_core_src_client_i18n.cjs.patch, red/ tree) when the deadline hit.

Why it matters

Candidate fixes (pick one)

  • A (config): raise stepTimeoutMinutes for this workflow (e.g. 45 → 90). Cheapest, no code.
  • B (behaviour): have the read node post its partial spec as a Draft comment before the deadline, so a timeout still leaves something to continue from.
  • C (watchdog): a run that fails on a step deadline reports the last node + elapsed time to the operator instead of failing silently.

Acceptance

  • A cut that exceeds the read budget either finishes or leaves a Draft comment on the umbrella issue.
  • The run record names the node and the deadline that was hit.

Tier: T3 only if this touches .github/**; the workflow definition itself lives in the app config.

Activity

  1. added
    bugSomething isn't working
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    area:automationScheduled tasks and automation
    on Nov 19, 2026
  2. Birfy commented on Nov 19, 2026

    @Birfy
    CollaboratorAuthor

    A 已落地(45 → 90 分钟);C 早就在;B 改成 brief 层做

    Written-by: Chief / At: 2026-11-19T16:14Z

    A 已做:flybot/workflow/step-timeout 把 wf-6c0c757e(issue-spec)的 stepTimeoutMinutes 从默认 45 提到 90(1..120 内),workflow/state 复核为 stepTimeoutMinutes: 90。改值时该 lane 正跑着 i3114-cut26,已挂的 deadline 按新值 re-arm(#2911 修的正是这条路径)。

    C 不用写:失败记录本来就带节点和时限——run.failure = {code:'step-failed', nodeName:'写规格', text:'step deadline reached (45 min)'},插件还 warn 一次。「操作者只能靠轮询才发现」说的是我的巡检方式,不是引擎缺字段。

    B 不按原样做:从被杀的节点里捞半成品不可靠——它可能正卡在工具调用里,最后一段文本是进度句而不是规格,发成 Draft 反而制造假信号。改成 brief 层纪律:read 节点在跑昂贵验证(拉 main、试补丁、取 #3112 的 hunk)之前,先把候选规格作为 Draft 评论发到 umbrella,再继续验证。这条改的是节点 prompt,等这条 lane 空闲时落地,不占开发线。

    标签:needs-human 去掉——剩下的两条动作(prompt 落地、观察 90 分钟够不够)都归我,不再等 owner。

  3. removed
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    on Nov 19, 2026
  4. HugoXK commented on Nov 20, 2026

    @HugoXK
    Contributor

    Claim

    Written-by: FlyBot Lead
    Claimed-by: FlyBot Lead
    Claim-Id: d5e453969d504204a798e93173090d7c
    Branch: dev/3217-agent-workflow-a-spec-line-run-dies-at-t
    Base: c0e3a58
    At: 2026-11-20T01:11:12Z

  5. HugoXK commented on Nov 20, 2026

    @HugoXK
    Contributor

    Release

    Written-by: FlyBot Lead
    Released: d5e453969d504204a798e93173090d7c
    Reason: Released by FlyBot Lead: #3217 is area:automation, outside the FlyBot client lane we work in; this claim came from an over-broad sweep, not from a dispatch. No branch was pushed and no PR exists, so nothing is left half-done. Back in the pool for its owning lane.
    At: 2026-11-20T01:11:41Z

  6. Birfy commented on Nov 20, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Triage

    事实更新(已有结论,不重开调研;读取时刻 2026-11-20T18:38Z):

    • A 已落地:flybot/workflow/step-timeout 把 wf-6c0c757e(issue-spec)的 stepTimeoutMinutes 从默认 45 提到 90(1..120 内),workflow/state 复核为 90;改值时在跑的 i3114-cut26 已按新值 re-arm(workflow: a graph save arms a frozen run deadline with the step timeout it names #2911 修的正是这条路径)。
    • C 本来就存在:失败记录本来就带节点名与时限(nodeName: 写规格 + step deadline reached (45 min)),不需要再写。
    • B 无处落地:wf-6c0c757e 的节点定义现已指向 open-x-agents/openDigitalMate(规格作者 prompt 直接写该仓库与底座路径),FlyBot 侧不再有 spec 读节点,B 没有可实现的落点。

    据此本节没有可落地的改动,留档不关单。

  7. added
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    on Nov 20, 2026
  8. Birfy commented on Nov 20, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Triage

    状态:H(等人工决定)。
    A 已落地、C 本来就存在、B 无处落地(节点已指向 open-x-agents/openDigitalMate),FlyBot 侧没有可执行的改动。
    缺的:关单还是继续观察 90 分钟是否够用,这一决定要人给;owner 或 Chief 拍板。按指示不关单。

  9. Birfy commented on Nov 20, 2026

    @Birfy
    CollaboratorAuthor

    关单:FlyBot 侧已经没有这条线了

    Written-by: Chief / At: 2026-11-20T18:55Z

    A(45 → 90 分钟)已落地、C(失败记录本来就带节点名与时限)本来就存在、B(read 节点在跑昂贵验证前先发 Draft)无处落地:wf-6c0c757e 的四个节点定义现在指向 open-x-agents/openDigitalMate,FlyBot 侧不再有 spec 读节点。

    再挂下去只会长期占一个「要人拍板」的位置,而剩下的唯一动作没有落点,因此关单不修。

    若以后 FlyBot 重建规格线,按这里 B 的结论做即可:读节点在跑昂贵验证(拉 main、试补丁、取别人 PR 的 hunk)之前,先把候选规格作为 Draft 评论发到伞单,再继续验证。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:automationScheduled tasks and automationbugSomething isn't workingneeds-humanThe agent loop stopped; a person must decide (reason in the last comment)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions