Skip to content

bot_schedules: a task title that carries a line break paints a second task row #3197

Closed

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: b0d679d36579489b83dd42ecdd25dd61
Branch: dev/1-schedules-title-one-line
Base: 0f7e821
At: 2026-11-19T01:20:35Z

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Bot: FlyBot Dev-1 (implementation) — found by FlyBot Product, audit of the bot_schedules row text
Tier: T2
Branch: dev/1-schedules-title-one-line

What is wrong

bot_schedules builds each row as one line of text and inserts the task's title into it verbatim: core/src/host/schedules.js:700 writes - "${entry.title ?? 'untitled'}" (${entry.id}) — …, and the only thing that ever touched the title is contentOf's String(body.title ?? '').trim() (:381) — trim, not folding. A title that carries a line break therefore paints a second row.

This is the same gap the diagnostics report closed in #3176 (a name inserted into a single-line field was folded before it reached the line); core/src/host/tasks.js:105 already owns the one-line helper the rest of the host uses for this.

Reproduction (red-first on live main 0f7e82121832d4cea8e26f1e9681355100432df7)

With the schedules.test.js fixture (setup() / scheduleService()), create a schedule whose title carries a newline — schedule-create accepts it (ok: true), and bot_schedules then returns two lines where the task is one row (rows.length 2 !== 1):

- "Brief
- "Injected" (s-fake) — next 2030-01-01T01:00:00.000Z, active, own chat, session w2" (schedule-1) — next …

Command:
cd core && TZ=UTC TMPDIR=/tmp node --import ./test/harness-resolve.mjs --test test/schedules.test.js

A model can do this by accident (a two-line title in a schedule-create call), and the forged line looks exactly like a real row.

Expected

  • a title that carries control characters or line breaks renders as one row line — folded to single-spaced text the way tasks.js:105/meetings.js:27 do it, with no other change to the row's shape;
  • a clean title's row is byte-identical to today, and the existing #2767/#3174 assertions (dead rows last, next … / no next run, and N more) stay untouched and green;
  • MAX_TITLE keeps counting what the reader sees: fold first, then count, so a title cannot become longer than the limit by folding; a folded title that lands under the limit must stay valid rather than being refused;
  • the stored title keeps being what schedule-create gave (no schema change), and bot_schedules is the one place that folds before printing — do not silently rewrite stored records.

Scope

  • core/src/host/schedules.js — fold at the row text
  • core/test/schedules.test.js — the red-first cases (newline, a bare CR, and a clean title that must stay byte-identical)
  • patches/ds-bot/0001-core-fixes.patch — node scripts/ds-bot-patches.mjs generate after the edit (never hand-edit the patch), then check and canonical
  • changelog.d/<this issue>.fixed.md
  • docs/subsystems/core-host.md — one sentence in the bot_schedules paragraph

Tier: core/src/host/** is T2 — a Verdict PASS at the exact tip is required. No UI surface (host answer text only).

Not in scope: the settings page's own input (plugins/**), the store's schema, the schedule's own execution, and any wording change to no next run / next … / and N more.

Duplicate check

Searched issues and PRs for schedule title newline, bot_schedules (only closed #3174, #2767, #628), and title + oneLine: nothing open matches. No duplicate.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions