Skip to content

social: the approve-all failure row renders with no CSS rule at all — a role=alert line looks like ordinary dock text #3192

Closed

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 938ed95e9c6e4295a4a0805f668cbbab
Branch: dev/5-chat-approval-error-style
Base: 9dc8e9f
At: 2026-11-19T00:27:29Z

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Bot: FlyBot Dev-5 (implementation)
Tier: T2
Branch: dev/5-chat-approval-error-style

What is wrong

The dock's Approve-all failure row renders as class="fs-chat-error" role="alert" (plugins/social/client.js:2852), but no CSS rule for that class has ever existed:

  • the plugin's injected stylesheet (the only source of fs-* rules — the repo tracks no .css file and the installed @deepseek-ai/* bundles contain no fs-chat-* at all) has .fs-chat-actions (:254) and .fs-chat-approval (:278-279), and nothing for fs-chat-error;
  • git log -S'.fs-chat-error' -- plugins/social/client.js is empty — the class was never styled, and it appears exactly once in the tree, at the render site;
  • so the row is painted with inherited dock text: role='alert' tells a screen reader, and nothing tells the eye. A failed Approve all reads like ordinary dock copy, directly above the cards whose reasons #3158/#3160 just made readable.

The plugin already owns the convention to use: .fs-status[data-tone=error]{color:#e5484d} (:170).

Reproduction (red-first on live main 9dc8e9fc54b689cb8d05dcbd7b083ca5deb91b9d)

plugins/social/test/approve-all-failure.test.js already loads the client source with readFileSync and drives the dock; a case that reads the injected stylesheet out of that same source and asks for a rule covering the alert row's own hook fails today, because no such rule exists (the assertion should name the class/attribute it looked for, and the colour or tone it expects — not just "some rule"). Same for the dock markup side: the row keeps data-flybot="chat-approval-error", which is what a test can pin against the stylesheet.

Run it on the unmodified base and quote the failure verbatim; a red-first case that cannot fail is not accepted.

Expected

  • the Approve-all failure row is visually distinguishable from the dock's body text, using the plugin's existing error tone (#e5484d / the .fs-status[data-tone=error] convention) — no new colour, no new font, no new copy;
  • it keeps role='alert' and data-flybot="chat-approval-error"; what it says does not change: #3160's 3-row cap, the {count} more not shown tail and the code-point cut all stay exactly as they are;
  • the rule survives the plugin's @media (max-width:640px) block without changing that block's touch-target sizes;
  • one test pins the rule (red today, green after), so a future stylesheet edit cannot silently drop it again.

Scope

Small, and only these files:

  • plugins/social/client.js — the rule (or the fs-status + data-tone=error reuse, if that is the more design-conformant way to say the same thing — say which in the PR and why)
  • plugins/social/test/approve-all-failure.test.js (or the file that already loads the client source for this alert) — the pinning case
  • changelog.d/<this issue>.fixed.md — the user-visible line
  • optionally one sentence in docs/subsystems/social.md where the dock is described

Not in scope: policy/gates.json gateFiles, .github/**, core/src/client/i18n.js (no copy change), core/client.js and patches/ds-bot/0008 (the single client bundle lane belongs to another slice), and any change to the row's text or caps.

Tier: plugins/** is T2 per .github/agent/risk-rules.json, so this needs a Verdict PASS at the exact tip; green CI alone does not merge it.

UI surface

Yes — the rendered role='alert' row changes. The PR carries before/after screenshots of the same approval dock after the same failed Approve-all click, same viewport as #3160 (420×560 CSS px at --force-device-scale-factor=2 → 840×1120 PNG each), real dock markup and the plugin's real CSS through the test harness, hosted under the repo's assets/<issue>/ convention on the fork branch. A UI PR with no screenshot gets no PASS (owner 2026-11-18).

Duplicate check

Searched issues and PRs for fs-chat-error (only closed hits: #3158/#3160 bounded the row's content, #3142 made it readable), approve all + unstyled/alert, and chat-approval-error: 0 open results. Nothing open covers the missing rule. plugins/social/client.js is not in patches/ds-bot/0008, so this does not touch the client-bundle single lane.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions