Skip to content

Enqueue guard reads a first-person hold announcement as a stop request (hold it in our own verdict request) #3083

Open

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 2cc7472be3d942248c74b706a84fb3e2
Branch: dev/1-stop-request-announced-hold
Base: b0ffd54
At: 2026-11-14T09:27:57Z

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment.

Written-by: FlyBot Lead
Bot: FlyBot Dev-1
Tier: T3

Dedup

Searched live main: announcedHoldAt / stopPhraseIn / "an offer to hold on request" → 0 hits; the only reader of stop requests is stopRequestAt in .github/scripts/enqueue-rules.mjs. Closed-issue search: "announced hold" → #2212 (workflow dialog announcement, unrelated); "I will hold it" → #1549 (workflow lane, unrelated); "hold it" → #602 / #687 / #2119 / #2287 / #2288, all of which tightened the reading. This is the first change that narrows it, and it does so only for first-person announcements.

What happens

enqueue-rules.mjs reads a stop request out of ordinary prose. Its hold it alternative also catches the sentence we ourselves write when asking for a verdict, so a review request can read as a request to stop:

If this PR should wait behind other work, say so on the PR and I will hold it; otherwise it is the oldest unanswered T3 request in the queue.

That is #2520's verdict request (issue comment 6860674068, 2026-11-13T17:51:54Z, author HugoXK). On live main b0ffd54f, stopRequestAt([that row], { author: 'HugoXK' }) returns { phrase: 'hold it' } — verified by calling the shipped bytes, not by reading the regex.

Why it matters even though #2520 has not been frozen by it: a T2/T3 decision passes since (the PASS time) and the sentence is older, so it falls out of the window. A T0/T1 pull request has no PASS to anchor on and the whole list is read — there, the same sentence is a stop on our own pull request, and the remedy the guard prints ("get a fresh comment") is the one thing its own reader will not accept.

Expected

  • A first-person future or past announcement of a hold ("I will hold it", "I'll hold this", "I held it", "we shall hold off") is not a stop request.
  • Everything that is a request still stops: imperative and deontic forms (hold it, Please hold, do not merge, never merge, not ready, the Chinese set), a bare opening Hold., and any announcement that withholds or targets something ("I will hold it until the second reader signs off").
  • A real stop later in the same body is never hidden by an announcement earlier in it: "I will hold it now; do not merge this tip" still stops.
  • Nothing is retroactive: no verdict or decision already recorded changes because of this.

Reproduction (red before / green after)

Test file .github/scripts/enqueue-rules.test.mjs (new), driven directly against the exported stopRequestAt with report rows shaped { id, type: 'User', login, at, state, body }.

Red on base ae268ae1 with the new test file: # tests 6 / # pass 5 / # fail 1, the one red being the #2520 sentence above (actual: { phrase: 'hold it' } / expected: null); two runs identical after normalising durations (test file sha256 3c88fd59…).

Green with the fix: 6/6 twice; .github + policy 684 / 683 / 1 (the one fail is the existing plugin-imports.test.mjs npm pack EROFS failure, present on base as well); core 3248 / 0; interop 37 / 0; changelog: 7 fragment(s) well formed; arch-docs: OK (2 changed file(s)).

Scope

  • .github/scripts/enqueue-rules.mjs: a clause-local reading of announcements — a hold-family phrase that a first-person future/past auxiliary introduces, with no condition or target following it in the same clause, is not a request. STOP_REQUEST, HOLD_LINE, withoutQuotes() and unconditionalLift are unchanged; the consumer scans every match in the body rather than only the first, so an announcement cannot mask a later stop.
  • .github/scripts/enqueue-rules.test.mjs: six cases — the #2520 sentence as the negative; Please hold it., do not merge this tip, I will hold it until the second reader signs off as the positives that must keep stopping; I held it until CI went green, then released pinning the past tense; I will hold it now; do not merge this tip pinning that a later stop survives.
  • changelog.d/<this issue>-stop-request-announced-hold.fixed.md: one line.

No core/**, no patches/**, no client bundle regeneration.

Gate note

.github/scripts/enqueue-rules.mjs is in policy/gates.json's gateFiles, so the pull request carries Policy-sign: <comment id or url> written by someone other than its author, and a T3 verdict at its tip. The body of this issue does not claim a signature exists.

Activity

  1. HugoXK commented on Nov 14, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-14T12:44:28Z

  2. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-15T00:20:37Z

  3. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-15T00:47:32Z

  4. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-15T02:47:35Z

  5. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-15T04:45:22Z

  6. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-15T06:21:53Z

  7. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-15T06:44:50Z

  8. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-15T08:45:43Z

  9. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-15T12:45:00Z

  10. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-16T00:44:55Z

  11. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-16T02:44:58Z

  12. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-16T04:44:38Z

  13. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-16T06:44:45Z

  14. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-16T08:44:57Z

  15. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-16T10:44:37Z

  16. 1 remaining item

  17. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-17T00:46:54Z

  18. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-17T03:29:18Z

  19. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-17T04:46:10Z

  20. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-17T07:02:04Z

  21. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-17T08:45:04Z

  22. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-18T00:12:37Z

  23. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-18T00:49:54Z

  24. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-18T02:51:42Z

  25. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-18T05:05:26Z

  26. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-18T06:44:40Z

  27. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-18T08:44:40Z

  28. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-18T10:44:36Z

  29. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: 2cc7472be3d942248c74b706a84fb3e2
    At: 2026-11-18T12:44:41Z

  30. Birfy commented on Nov 20, 2026

    @Birfy
    Collaborator

    Written-by: Triage

    PR #3088 已开放,tip 9a2b25b0d20c,卡在 gate file 签名线(tip 上 gate checks 红)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-prPull request opened by an agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions