Skip to content

Require a changelog fragment for user-visible client changes at enqueue time #3066

Open

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: dfddd1297c094b41a8dfc70778143d10
Branch: dev/5-missing-changelog-fragment
Base: 36efafb
At: 2026-11-14T01:50:23Z

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment.

Written-by: FlyBot Lead
Bot: FlyBot Dev-5

Problem

A change users can see can be merged with no changelog.d/ fragment, and then it is missing from the release notes. CONTRIBUTING.md asks for a fragment, but nothing checks it mechanically: changelog.mjs assembles a release from fragments only, so an absent fragment is simply invisible.

Five user-visible fixes merged before the v0.2.32 cut (merged 2026-11-13T18:10:48Z) carried no fragment and are absent from that release body: #3027 (kept-clash row shows the saved spelling), #3031 (Approve all receipt "Sent to {to}"), #3033 (face-leave: a published seat must leave Friends' Bots), #3035 (a room hold row opens a local session), #3038 (a hold that fails elsewhere is listed in the dock with Retry). A published release cannot be corrected afterwards — the fragments are consumed at cut time.

Reproduction (current behaviour)

On live main 36efafb8, a PR whose files are plugins/social/client.js and whose body has no fragment passes enqueue-guard unchanged. enqueue-rules.mjs has no rule that looks at changelog.d/; risk-gate.mjs reports nothing blocking either.

Red-first, twice on a clean 36efafb8 with only the new tests added (byte-identical after stripping durations, 158 pass / 2 fail):

  • not ok 156 - a user-visible change with no changelog fragment and no exemption is refused, and the file is named — true !== false (the guard lets it through)
  • not ok 160 - the rule also holds on a fork pull request, which skips the issue and label rules — true !== false

Expected

At enqueue time, a change that touches a user-visible client path must carry either a changelog.d/*.md fragment or an explicit exemption line in the PR body:

  • "user-visible" is defined mechanically by path, not by the PR title: core/src/client/** or plugins/*/client.js;
  • exemption is one line changelog-not-needed: <reason of at least 10 characters>, mirroring the existing Docs-not-needed: shape;
  • the rule must also apply to fork PRs — ours all come from forks, and the existing issue-reference / agent-pr rules sit behind !fork, so placing this rule there would skip every PR we open;
  • already-merged PRs are not re-judged (only !draft && !merged).

Scope

  • .github/scripts/enqueue-rules.mjs — the rule, guarded by !draft && !merged, outside the !fork branch.
  • .github/scripts/enqueue-guard.test.mjs — five cases: refused and named; fragment passes; exemption line passes; pure test/docs change is not caught; fork PR still caught.
  • .github/scripts/merge-gate.test.mjs — the #654 T1 fixture gains the fragment that this rule requires (the fixture was modelling a user-visible change with no fragment).
  • CONTRIBUTING.md — one line stating the fragment rule is checked mechanically at enqueue time.
  • changelog.d/<this issue>-user-visible-changelog-fragment.fixed.md.

Tier: T3 (.github/**).

Landing cost

When the rule lands, an in-flight PR that touches plugins/social/client.js or core/src/client/** without a fragment or exemption turns red at enqueue. That is intended; the affected PR gets its fragment/waiver in its own branch.

Dedup

Searched live main for changelog.d / changelog-not-needed and the open issue list for the same face: no open issue proposes a mechanical fragment gate. Closed #916, #1609, #2595, #1741, #3057 are all manual backfill or date fixes — none adds a gate. No open PR touches enqueue-rules.mjs.

Activity

  1. HugoXK commented on Nov 14, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-14T02:47:26Z

  2. HugoXK commented on Nov 14, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-14T04:46:02Z

  3. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-15T00:47:16Z

  4. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-15T02:47:40Z

  5. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-15T04:45:13Z

  6. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-15T06:21:44Z

  7. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-15T06:44:42Z

  8. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-15T08:45:34Z

  9. HugoXK commented on Nov 15, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-15T12:44:51Z

  10. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-16T00:44:45Z

  11. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-16T02:44:50Z

  12. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-16T04:44:30Z

  13. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-16T06:44:36Z

  14. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-16T08:44:47Z

  15. HugoXK commented on Nov 16, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-16T10:44:28Z

  16. 1 remaining item

  17. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-17T00:46:46Z

  18. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-17T03:29:09Z

  19. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-17T04:46:02Z

  20. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-17T07:01:56Z

  21. HugoXK commented on Nov 17, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-17T08:44:55Z

  22. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-18T00:12:28Z

  23. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-18T00:49:45Z

  24. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-18T02:51:34Z

  25. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-18T05:05:18Z

  26. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-18T06:44:31Z

  27. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-18T08:44:32Z

  28. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-18T10:44:28Z

  29. HugoXK commented on Nov 18, 2026

    @HugoXK
    ContributorAuthor

    Heartbeat

    Written-by: FlyBot Lead
    Still-working: dfddd1297c094b41a8dfc70778143d10
    At: 2026-11-18T12:44:30Z

  30. Birfy commented on Nov 20, 2026

    @Birfy
    Collaborator

    Written-by: Triage

    PR #3067 已开放,tip 8a9123ad8f3c,卡在 gate file 签名线:签名线之前的 PR 合不了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-prPull request opened by an agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions