Skip to content

feat(support): add optional self-cast outside Support Mode - #212

Open
DEVLlN wants to merge 5 commits into
ThericGames:developfrom
DEVLlN:feat/self-cast-outside-support
Open

DEVLlN wants to merge 5 commits into
ThericGames:developfrom
DEVLlN:feat/self-cast-outside-support

Conversation

@DEVLlN

@DEVLlN DEVLlN commented Nov 13, 2026 •

Copy link
Copy Markdown

Summary

Add Reticle Targeting → Self-cast outside Support Mode, an opt-in setting for helpful spells cast using Click Casting or action-bar keys handled by Reticle Targeting. Enable it if you use normal-mode casts for self-heals and switch to Support Mode when healing allies. Inside Support Mode, keyboard keys use regular action-bar targeting and Click Casting keeps its ally routing and the hold-to-self-cast key.

The setting is on the Reticle Targeting tab because it affects keyboard action-bar keys as well as Click Casting. It reuses the self-cast macro text added in #207. Custom macros, unsupported bars, and harmful spells follow their existing routes. Click Casting Only continues to control whether Reticle Targeting handles keyboard keys.

Validation

  • Updated from develop and updated the tooltip, translations, docs, and changelog.
  • Lint and LuaJIT specs passed across eight client configurations. The specs cover normal-mode self-cast, ordinary keyboard targeting during Support Mode, the click-cast ally route, alternate pages, ranked spells, exclusions, and missing spell data.
  • In-game validation on Retail, Forever, and Classic.

@sampconrad sampconrad left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Needs changes before merge:

  • Rebase onto develop. #207 already added a self-cast text as SupportCastLine's second return. Please reuse it instead of the selfOnly parameter and a second /cast [@player] builder.
  • Explain the use case. Since the Support Mode hold key exists now, when would someone want self-cast as the default instead? The tooltip should say so.
  • Scope. Support Mode only acts on click casting (the bar page you select in its settings), and keyboard keys are outside it. This option sits on the Support Mode tab but would also change keyboard keys. Please make it affect click-cast bindings only, or move it off the Support Mode tab.
  • Docs. Update the comment above SupportCastLine and domain-click-casting.md, which now say the addon has no self-cast option of its own. Also update the TabSupportMode.lua header.
  • Housekeeping. Fix the PR title (feat: ...) and add a CHANGELOG.md entry.
  • Clients. Please test on Retail, Forever and Classic and check for Lua errors.

@DEVLlN DEVLlN changed the title Add optional self-casting outside Support Mode feat(support): add optional self-cast outside Support Mode Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants