Repository navigation
Conversation
sampconrad
requested changes
Nov 19, 2026
Collaborator
There was a problem hiding this comment.
Thanks for this. Needs changes before merge:
- Rebase onto
develop. #207 already added a self-cast text asSupportCastLine's second return. Please reuse it instead of theselfOnlyparameter and a second/cast [@player]builder. - Explain the use case. Since the Support Mode hold key exists now, when would someone want self-cast as the default instead? The tooltip should say so.
- Scope. Support Mode only acts on click casting (the bar page you select in its settings), and keyboard keys are outside it. This option sits on the Support Mode tab but would also change keyboard keys. Please make it affect click-cast bindings only, or move it off the Support Mode tab.
- Docs. Update the comment above
SupportCastLineanddomain-click-casting.md, which now say the addon has no self-cast option of its own. Also update theTabSupportMode.luaheader. - Housekeeping. Fix the PR title (
feat: ...) and add aCHANGELOG.mdentry. - Clients. Please test on Retail, Forever and Classic and check for Lua errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Reticle Targeting → Self-cast outside Support Mode, an opt-in setting for helpful spells cast using Click Casting or action-bar keys handled by Reticle Targeting. Enable it if you use normal-mode casts for self-heals and switch to Support Mode when healing allies. Inside Support Mode, keyboard keys use regular action-bar targeting and Click Casting keeps its ally routing and the hold-to-self-cast key.
The setting is on the Reticle Targeting tab because it affects keyboard action-bar keys as well as Click Casting. It reuses the self-cast macro text added in #207. Custom macros, unsupported bars, and harmful spells follow their existing routes. Click Casting Only continues to control whether Reticle Targeting handles keyboard keys.
Validation
developand updated the tooltip, translations, docs, and changelog.