Skip to content

feat(target-lock): add option to hide the Blizzard focus frame - #210

Open
DEVLlN wants to merge 3 commits into
ThericGames:developfrom
DEVLlN:feat/hide-focus-frame
Open

DEVLlN wants to merge 3 commits into
ThericGames:developfrom
DEVLlN:feat/hide-focus-frame

Conversation

@DEVLlN

@DEVLlN DEVLlN commented Nov 13, 2026 •

Copy link
Copy Markdown

Summary

Add Hide Focus Frame to the Target Lock section of Reticle Targeting. The per-character option defaults off. Players using focus for Target Lock can hide Blizzard's redundant focus unit frame while retaining their focus, Target Lock, macros and nameplate lock marker.

The new FocusFrameVisibility module reparents Blizzard's frame under a hidden holder out of combat. It leaves native show/hide and unit-watch behavior intact. Disabling restores the original parent if the module still owns it. Edit Mode temporarily restores the Blizzard frame, and the addon respects a parent taken over by another addon. Bootstrap applies the saved preference; combat end applies the latest preference after any changes made during combat. Third-party replacement unit frames are not modified.

Player impact

Opt-in suppression of the Blizzard focus frame, with an immediate out-of-combat toggle and restoration. Includes all 11 locale entries and current-version changelog.

Test plan

  • Passed LuaJIT load tests: 720 file loads across 8 client configurations plus unit specs, run with Lupa LuaJIT 2.1.
  • Added checks for default-off behavior, combat deferral in both directions, repeated application, original-parent restoration, another addon taking parent ownership, and numeric false settings.
  • StyLua, Selene, locale/changelog/load-order checks and WoW-global checks passed. Confirmed FocusFrame through the repository's Blizzard-source scanner. Ran lint-changed twice after fixes.
  • Repository, globals, and LuaJIT load/spec checks pass on the updated branch. FocusFrame and EditModeManagerFrame are recorded in the manual globals list.
  • Current-version changelog and generated changelog updated.
  • In-game Retail and Forever/Classic validation remains pending.
  • Toggle with/without focus, lock/cycle/unlock enemies and allies, reload with the option enabled, and verify mouse interaction is not blocked by an invisible frame.
  • Toggle in combat and verify no protected changes until combat ends; verify focus-frame restoration and compatibility with Edit Mode/unit-frame addons.

@sampconrad sampconrad left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @DEVLlN. The approach is simple and low-risk, combat is deferred correctly, and the spec covers the ownership cases well. A few things need fixing before merge.

Blocking

  1. The new locale strings are corrupted. Accented and non-Latin characters became literal ? in the ten translated files. Examples are zu l?schen and ?nderungen (deDE), appliqu?s apr?s (frFR) and Altera??es (ptBR). koKR, ruRU, zhCN and zhTW are essentially all question marks. Please re-write them as UTF-8. check-repo only checks that the keys exist, so it won't catch this.
  2. The branch conflicts with develop. After resolving, regenerate ChangelogData.lua with pwsh ./scripts/sync-changelog-to-lua.ps1 instead of merging it by hand.
  3. FocusFrame was added to the generated scripts/data/wow-globals.txt. check-globals -Update will drop it. Blizzard defines this frame in XML, so the scanner can't see it. It belongs in scripts/data/wow-globals-manual.txt with a reason.

Should fix or confirm

  • Edit Mode. FocusFrame is an Edit Mode managed frame. Reparenting it can make it invisible while editing the layout, and it may taint Blizzard's layout code. Please test with Edit Mode open and the option on.
  • Re-enable path. If another addon took the parent and the option is then toggled off and on, originalParent is read from that other addon's parent, so a later restore goes to the wrong place.
  • newFeatureFlag = true on the whole reticle tab isn't mentioned in the PR. Please confirm it's intentional or keep only the toggle's flag.
  • Clients. Please test on Retail, Forever and Classic and check that hiding and restoring the frame works with no Lua errors.
  • domain-crosshair.md. The new note comes after the In-game checks line. That line is meant to stay last in the file.

Before merge

  • Please do the in-game checks from your test plan: reload with the option on, toggling in and out of combat, Edit Mode, unit-frame addons, and Forever.
  • Run pwsh ./scripts/lint-changed.ps1 twice once the conflicts are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants