Repository navigation
Conversation
sampconrad
self-requested a review
November 14, 2026 03:07
sampconrad
requested changes
Nov 19, 2026
Collaborator
There was a problem hiding this comment.
Thanks for this, @DEVLlN. The approach is simple and low-risk, combat is deferred correctly, and the spec covers the ownership cases well. A few things need fixing before merge.
Blocking
- The new locale strings are corrupted. Accented and non-Latin characters became literal
?in the ten translated files. Examples arezu l?schenand?nderungen(deDE),appliqu?s apr?s(frFR) andAltera??es(ptBR). koKR, ruRU, zhCN and zhTW are essentially all question marks. Please re-write them as UTF-8.check-repoonly checks that the keys exist, so it won't catch this. - The branch conflicts with
develop. After resolving, regenerateChangelogData.luawithpwsh ./scripts/sync-changelog-to-lua.ps1instead of merging it by hand. FocusFramewas added to the generatedscripts/data/wow-globals.txt.check-globals -Updatewill drop it. Blizzard defines this frame in XML, so the scanner can't see it. It belongs inscripts/data/wow-globals-manual.txtwith a reason.
Should fix or confirm
- Edit Mode.
FocusFrameis an Edit Mode managed frame. Reparenting it can make it invisible while editing the layout, and it may taint Blizzard's layout code. Please test with Edit Mode open and the option on. - Re-enable path. If another addon took the parent and the option is then toggled off and on,
originalParentis read from that other addon's parent, so a later restore goes to the wrong place. newFeatureFlag = trueon the wholereticletab isn't mentioned in the PR. Please confirm it's intentional or keep only the toggle's flag.- Clients. Please test on Retail, Forever and Classic and check that hiding and restoring the frame works with no Lua errors.
domain-crosshair.md. The new note comes after the In-game checks line. That line is meant to stay last in the file.
Before merge
- Please do the in-game checks from your test plan: reload with the option on, toggling in and out of combat, Edit Mode, unit-frame addons, and Forever.
- Run
pwsh ./scripts/lint-changed.ps1twice once the conflicts are resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Hide Focus Frame to the Target Lock section of Reticle Targeting. The per-character option defaults off. Players using focus for Target Lock can hide Blizzard's redundant focus unit frame while retaining their focus, Target Lock, macros and nameplate lock marker.
The new FocusFrameVisibility module reparents Blizzard's frame under a hidden holder out of combat. It leaves native show/hide and unit-watch behavior intact. Disabling restores the original parent if the module still owns it. Edit Mode temporarily restores the Blizzard frame, and the addon respects a parent taken over by another addon. Bootstrap applies the saved preference; combat end applies the latest preference after any changes made during combat. Third-party replacement unit frames are not modified.
Player impact
Opt-in suppression of the Blizzard focus frame, with an immediate out-of-combat toggle and restoration. Includes all 11 locale entries and current-version changelog.
Test plan