Repository navigation
Conversation
…only The anonymous network iCal feed and network events CSV export included events awaiting approval and events of unapproved groups. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #945.
What changes
/calendar/network/{id}, anonymous). Before, it listed every non-deleted event of every group in the network, including events still awaiting approval and events of groups that haven't been approved. Now it lists only approved events of approved groups./export/networks/{id}/events, anonymous CSV). Same change: before, it included unapproved events and unapproved groups' events; now it includes only approved events of approved groups.Both URLs need no login, so anyone with a network id could see events that hadn't been approved yet.
Tests:
CalendarTest::testByNetworkExcludesUnapproved;ExportTestnow expects the unapproved group's event to be left out of the network export.