Repository navigation
docs(openspec): propose fix-velocity-sampling - #6
Merged
Merged
Conversation
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 30, 2026
## <small>1.6.1 (2026-10-30)</small> * fix(velocity): start sampling and keep proxy gauges current (#7) ([b5b09b2](b5b09b2)), closes [#7](#7) * docs: add community guidelines and security policy ([1d4f9fe](1d4f9fe)) * docs: update issue and pull request templates to use consistent English wording ([7063da7](7063da7)) * docs(openspec): propose fix-velocity-sampling (#6) ([8b3e5fc](8b3e5fc)), closes [#6](#6) * chore(openspec): initialize openspec (#5) ([f2b6b52](f2b6b52)), closes [#5](#5) * refactor: split platform samplers into separate implementations ([b21f436](b21f436)) * Merge branch 'main' of https://github.com/TheMeinerLP/MinecraftOTEL ([f15ad2b](f15ad2b)) * ci: add GitHub Actions workflow to publish Javadocs on release ([900eff5](900eff5))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every Velocity proxy logs an error at startup: the sampling task is registered under the wrong owner, so the proxy rejects it. Sampling stops after the first sample, which means proxy dashboards show frozen zeros for every proxy gauge. Backend changes also linger in the metrics after a backend is removed. This change proposes the fix: start sampling under the plugin, keep the exported proxy values in step with the live network, and add the first automated tests for this code path.
Change Type
Tests
Details:
openspec validate --strictpassed.Checklist